From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752176AbaJFCJ6 (ORCPT ); Sun, 5 Oct 2014 22:09:58 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:39857 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751809AbaJFCJ4 (ORCPT ); Sun, 5 Oct 2014 22:09:56 -0400 Date: Sun, 5 Oct 2014 19:09:50 -0700 From: Guenter Roeck To: Greg KH Cc: Jason Noakes , linux-kernel Subject: Re: kobject_init and the zeroed-out-memory requirement Message-ID: <20141006020950.GA29722@roeck-us.net> References: <20141005202843.GA1282@kroah.com> <20141005215100.GA20426@kroah.com> <20141005232457.GA22525@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141005232457.GA22525@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 05, 2014 at 04:24:57PM -0700, Greg KH wrote: > On Sun, Oct 05, 2014 at 06:13:05PM -0400, Jason Noakes wrote: > > > No driver should be working with "raw" kobjects. > > > > I don't agree, but it's irrelevant. > > Not at all. I'd wager that if a driver is messing around with a "raw" > kobject, it is doing something seriously wrong. Of course there are > exceptions, but those are very rare, and exceptions. A driver should be > using the driver core, and the functions and objects provided there, and > provided by the bus it lives on. > > So, have a pointer to some driver code that is calling > kobject_initialize()? I'd love to see it. > Lots to choose from. In drivers/: $ git grep kobject_init | wc 65 289 4880 $ git grep kobject_init | grep -v base | wc 62 277 4694 $ git grep kobject_init_and_add | grep -v base | wc 47 232 3698 $ git grep kobject_add | grep -v base | wc 20 111 1486 Guenter