From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 06 Oct 2014 14:49:18 +0200 (CEST) Received: from localhost.localdomain ([127.0.0.1]:57948 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S27009833AbaJFMtRG0-yx (ORCPT ); Mon, 6 Oct 2014 14:49:17 +0200 Received: from scotty.linux-mips.net (localhost.localdomain [127.0.0.1]) by scotty.linux-mips.net (8.14.8/8.14.8) with ESMTP id s96CnGF3029941; Mon, 6 Oct 2014 14:49:16 +0200 Received: (from ralf@localhost) by scotty.linux-mips.net (8.14.8/8.14.8/Submit) id s96CnF4Q029940; Mon, 6 Oct 2014 14:49:15 +0200 Date: Mon, 6 Oct 2014 14:49:15 +0200 From: Ralf Baechle To: Joe Perches Cc: linux-mips , LKML Subject: Re: [PATCH] mips: Convert pr_warning to pr_warn Message-ID: <20141006124915.GA29036@linux-mips.org> References: <1412441442.3247.138.camel@joe-AO725> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1412441442.3247.138.camel@joe-AO725> User-Agent: Mutt/1.5.23 (2014-03-12) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 42962 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ralf@linux-mips.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Sat, Oct 04, 2014 at 09:50:42AM -0700, Joe Perches wrote: > Use the much more common pr_warn instead of pr_warning > with the goal of removing pr_warning eventually. While I agree that only one of pr_warn and pr_warning deserves to live picking pr_warning introduces another logic inconsistency - for each pr_ function there is a KERN_ severity symbol. And that in this case is named KERN_WARNING, there's no KERN_WARN. Ralf