From: "Steinar H. Gunderson" <sgunderson@bigfoot.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v6 2/2] mac80211: support DTPC IE (from Cisco Client eXtensions)
Date: Mon, 6 Oct 2014 16:54:34 +0200 [thread overview]
Message-ID: <20141006145434.GA35618@sesse.net> (raw)
In-Reply-To: <1412607134.3098.25.camel@jlt4.sipsolutions.net>
On Mon, Oct 06, 2014 at 04:52:14PM +0200, Johannes Berg wrote:
>> I found what I believe is an edge case: What happens if the element suddenly
>> goes away from one beacon to another? Shouldn't there be a reset of the power
>> level and then a new call to __ieee80211_recalc_txpower()?
>>
>> (If so, I believe this bug was already present in the code before my first
>> patch, as I understand the existing logic.)
> I'm not sure it's worth worrying about, but if you want to write a patch
> I'd take it :)
It actually happened to me in a real situation, which is why I noticed.
It seems neither power element is typically sent at all if the value is 0.
(Well, Aruba seems to do. I haven't found anyone else who does.)
/* Steinar */
--
Homepage: http://www.sesse.net/
next prev parent reply other threads:[~2014-10-06 14:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-23 21:28 [PATCH] Support Cisco DTPC IE to reduce transmit power Steinar H. Gunderson
2014-08-24 10:37 ` Steinar H. Gunderson
2014-08-24 10:08 ` [PATCH] Support DTPC IE (from Cisco Client eXtensions) Steinar H. Gunderson
2014-08-28 7:43 ` Johannes Berg
2014-08-28 8:37 ` Steinar H. Gunderson
2014-08-29 8:19 ` Steinar H. Gunderson
2014-08-29 17:27 ` [PATCH 1/2] mac80211: split 802.11h parsing from transmit power policy Steinar H. Gunderson
2014-08-29 17:38 ` [PATCH 2/2] mac80211: support DTPC IE (from Cisco Client eXtensions) Steinar H. Gunderson
2014-08-30 0:24 ` [PATCH] Support " Steinar H. Gunderson
2014-08-30 18:45 ` Steinar H. Gunderson
2014-08-29 17:27 ` [PATCH 1/2] mac80211: split 802.11h parsing from transmit power policy Steinar H. Gunderson
2014-08-29 17:27 ` [PATCH v5 " Steinar H. Gunderson
2014-09-03 11:56 ` Johannes Berg
2014-09-03 13:21 ` Steinar H. Gunderson
2014-08-29 17:38 ` [PATCH v5 2/2] mac80211: support DTPC IE (from Cisco Client eXtensions) Steinar H. Gunderson
2014-09-03 12:00 ` Johannes Berg
2014-09-03 13:33 ` Steinar H. Gunderson
2014-09-03 13:22 ` [PATCH v6 1/2] mac80211: split 802.11h parsing from transmit power policy Steinar H. Gunderson
2014-09-03 13:48 ` [PATCH v6 2/2] mac80211: support DTPC IE (from Cisco Client eXtensions) Steinar H. Gunderson
2014-09-08 8:53 ` Johannes Berg
2014-09-16 23:47 ` Steinar H. Gunderson
2014-10-06 14:52 ` Johannes Berg
2014-10-06 14:54 ` Steinar H. Gunderson [this message]
2014-09-03 19:12 ` [PATCH v5 " Johannes Berg
2014-09-07 17:02 ` Steinar H. Gunderson
2014-08-29 17:38 ` [PATCH " Steinar H. Gunderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141006145434.GA35618@sesse.net \
--to=sgunderson@bigfoot.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.