All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libxml2: Add patch to remove weak symbol trickery
Date: Mon, 6 Oct 2014 19:17:59 +0200	[thread overview]
Message-ID: <20141006171759.GA4122@free.fr> (raw)
In-Reply-To: <1744839.Qfi6dWdBgg@hyperion>

Maarten, All,

On 2014-10-06 01:29 +0200, Maarten ter Huurne spake thusly:
> On Sunday 05 October 2014 19:35:57 Thomas Petazzoni wrote:
> > On Thu, 11 Sep 2014 06:38:45 +0200, Maarten ter Huurne wrote:
> > > This avoids runtime problems when linking libpthread statically and it
> > > fixes compilation with musl libc.
> > > 
> > > The patch is based on this one:
> > >   https://github.com/sabotage-linux/sabotage/blob/master/KEEP/libxml2-pt
> > >   hread.patch> 
> > > I added the configure modification to ensure that libxml-2.0.pc will
> > > list libpthread as a private dependency.
> > 
> > Missing SoB line.
> 
> Is there a policy for including 3rd party patches? In this case the fragment 
> I took from Sabotage Linux only removes code, so I don't think there could 
> be any copyright issues there (no creativity involved), but in general would 
> my SoB line be sufficient or would I need one from the 3rd party author as 
> well?

When using a patch from somewhere else:
  - take the patch as-is,
  - add to the description of that patch the URL where you got it: an
    upstream commit, a bug-tracker, a mailing...
  - add your own SoB line.

That way, proper attribution is done, both for the original author(s)
and you.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2014-10-06 17:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-11  4:38 [Buildroot] [PATCH] libxml2: Add patch to remove weak symbol trickery Maarten ter Huurne
2014-10-05 17:35 ` Thomas Petazzoni
2014-10-05 23:29   ` Maarten ter Huurne
2014-10-06 17:17     ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141006171759.GA4122@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.