From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC/PATCH 1/1] gst-fsl-plugins: fix compile for sysroot based on newer linux kernel headers
Date: Mon, 6 Oct 2014 17:18:14 +0200 [thread overview]
Message-ID: <20141006171814.378d6558@free-electrons.com> (raw)
In-Reply-To: <1393366722-27644-2-git-send-email-ps.report@gmx.net>
Dear Peter Seiderer,
On Tue, 25 Feb 2014 23:18:42 +0100, Peter Seiderer wrote:
> The v4l2 ioctl VIDIOC_DBG_G_CHIP_IDENT was removed in linux-3.11 (see [1]/[2]).
>
> To avoid build failure of the gst-fsl-plugins/mfw_gst_v4lsrc with toolchains based
> on newer linux kernel headers this patch gives the include of the custom linux
> kernel headers precedence over the sysroot linux kernel headers (oposed to the
> previous behavior).
>
> Fixes the following compile error with buildroot/glibc toolchain:
>
> mfw_gst_v4lsrc.c: In function 'mfw_gst_v4lsrc_capture_setup':
> mfw_gst_v4lsrc.c:452:10: error: variable 'chip' has initializer but incomplete type
> struct v4l2_dbg_chip_ident chip = {0};
> ^
> mfw_gst_v4lsrc.c:452:10: warning: excess elements in struct initializer [enabled by default]
> mfw_gst_v4lsrc.c:452:10: warning: (near initialization for 'chip') [enabled by default]
> mfw_gst_v4lsrc.c:452:30: error: storage size of 'chip' isn't known
> struct v4l2_dbg_chip_ident chip = {0};
> ^
> mfw_gst_v4lsrc.c:464:22: error: 'VIDIOC_DBG_G_CHIP_IDENT' undeclared (first use in this function)
> if (ioctl (fd_v4l, VIDIOC_DBG_G_CHIP_IDENT, &chip)) {
> ^
>
> [1] http://www.spinics.net/lists/linux-media/msg64081.html
> [2] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/include/uapi/linux/videodev2.h?id=b71c99801e18eb172ae34851daf25044a3bf644a
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I believe this problem has been fixed by the following commit:
commit daf3708be46d7eb7e9352ee987f37e32eb00c6bd
Author: Gary Bisson <bisson.gary@gmail.com>
Date: Fri Jul 25 22:34:30 2014 -0700
gst-fsl-plugins: fix build for kernel headers >= 3.10
This package couldn't build using a toolchain with kernel headers >=
3.10 because of the use of VIDIOC_DBG_G_CHIP_IDENT. As stated in
videodev2.h, this ioctl should never be used.
Signed-off-by: Gary Bisson <bisson.gary@gmail.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Therefore, I'm marking your patch as Superseded in our patch tracking
system.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-10-06 15:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 22:18 [Buildroot] [RFC/PATCH 0/1] gst-fsl-plugins: fix compile for sysroot based on newer linux kernel headers Peter Seiderer
2014-02-25 22:18 ` [Buildroot] [RFC/PATCH 1/1] " Peter Seiderer
2014-03-02 8:48 ` Thomas Petazzoni
2014-03-04 17:40 ` Arnout Vandecappelle
2014-03-04 21:50 ` Thomas Petazzoni
2014-04-19 21:56 ` Thomas Petazzoni
2014-10-06 15:18 ` Thomas Petazzoni [this message]
2014-02-25 22:28 ` [Buildroot] [RFC/PATCH 0/1] " Peter Korsgaard
2014-02-25 22:53 ` Peter Seiderer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141006171814.378d6558@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.