From: Josh Triplett <josh@joshtriplett.org>
To: Joe Perches <joe@perches.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Julia Lawall <julia.lawall@lip6.fr>,
Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH net-next] net: validate_xmit_vlan() is static
Date: Mon, 6 Oct 2014 12:07:29 -0700 [thread overview]
Message-ID: <20141006190728.GA2137@thin> (raw)
In-Reply-To: <1412621042.2916.29.camel@joe-AO725>
On Mon, Oct 06, 2014 at 11:44:02AM -0700, Joe Perches wrote:
> On Mon, 2014-10-06 at 11:26 -0700, Eric Dumazet wrote:
> > From: Eric Dumazet <edumazet@google.com>
> >
> > Marking this as static allows compiler to inline it.
>
> Found by inspection or another tool?
>
> Wasn't there some tool to look for non-static functions
> that are not called externally that could/should be
> converted to static?
Several: sparse, gcc -Wmissing-prototypes, and findstatic.pl.
next prev parent reply other threads:[~2014-10-06 19:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 18:26 [PATCH net-next] net: validate_xmit_vlan() is static Eric Dumazet
2014-10-06 18:44 ` Joe Perches
2014-10-06 19:07 ` Josh Triplett [this message]
2014-10-06 19:36 ` Joe Perches
2014-10-06 19:35 ` Eric Dumazet
2014-10-06 22:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141006190728.GA2137@thin \
--to=josh@joshtriplett.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=error27@gmail.com \
--cc=joe@perches.com \
--cc=julia.lawall@lip6.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.