From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [PATCH v2] KVM: x86: some apic broadcast modes does not work
Date: Mon, 6 Oct 2014 21:08:49 +0200
Message-ID: <20141006190848.GB1918@potion.brq.redhat.com>
References: <1412285452-27062-1-git-send-email-namit@cs.technion.ac.il>
 <20141003124912.GA28730@potion.brq.redhat.com>
 <EC47137F-F7CA-4436-82A7-6F1F378EB41C@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Nadav Amit <namit@cs.technion.ac.il>, pbonzini@redhat.com,
	kvm@vger.kernel.org
To: Nadav Amit <nadav.amit@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:27081 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753011AbaJFTJC (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 6 Oct 2014 15:09:02 -0400
Content-Disposition: inline
In-Reply-To: <EC47137F-F7CA-4436-82A7-6F1F378EB41C@gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

2014-10-06 18:29+0300, Nadav Amit:
> On Oct 3, 2014, at 3:49 PM, Radim Kr=C4=8Dm=C3=A1=C5=99 <rkrcmar@redh=
at.com> wrote:
> > 2014-10-03 00:30+0300, Nadav Amit:
> > Reviewed-by: Radim Kr=C4=8Dm=C3=A1=C5=99 <rkrcmar@redhat.com>
> >=20
> >> +#define X2APIC_BROADCAST		0xFFFFFFFFul
> >=20
> > (int is better -- using long introduces an interesting feature with
> > implicit retyping: (int)X2APIC_BROADCAST !=3D X2APIC_BROADCAST, and=
 we
> > don't compile with -Wtype-limits to notice it.  It poses no problem
> > now, so I can change it in an inevitable cleanup series / convince =
lkml
> > to endorse stricter warnings.)
> Would unsigned int ease your mind?

That would be perfect.

> >> -int kvm_apic_match_physical_addr(struct kvm_lapic *apic, u16 dest=
)
> >> +static int kvm_apic_broadcast(struct kvm_lapic *apic, u32 dest)
> >=20
> > (bool is better.)
> Ok. I will do it for v3.

I'm fine with v2, which is why the nitpicking was in parentheses.