From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH 07/44] qnap-poweroff: Drop reference to pm_power_off from devicetree bindings Date: Tue, 7 Oct 2014 12:02:19 +0100 Message-ID: <20141007110219.GE24725@leverpostej> References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-8-git-send-email-linux@roeck-us.net> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <1412659726-29957-8-git-send-email-linux@roeck-us.net> Sender: linux-acpi-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Guenter Roeck Cc: "linux-kernel@vger.kernel.org" , "adi-buildroot-devel@lists.sourceforge.net" , "devel@driverdev.osuosl.org" , "devicetree@vger.kernel.org" , "lguest@lists.ozlabs.org" , "linux-acpi@vger.kernel.org" , "linux-alpha@vger.kernel.org" , "linux-am33-list@redhat.com" , "linux-cris-kernel@axis.com" , "linux-efi@vger.kernel.org" , "linux-hexagon@vger.kernel.org" , "linux-m32r-ja@ml.linux-m32r.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-s390@vger.kernel.org" , lin On Tue, Oct 07, 2014 at 06:28:09AM +0100, Guenter Roeck wrote: > Replace reference to pm_power_off (which is an implementation detail) > and replace it with a more generic description of the driver's functionality. > > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Signed-off-by: Guenter Roeck > --- > Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt b/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > index af25e77..1e2260a 100644 > --- a/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > +++ b/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > @@ -3,8 +3,8 @@ > QNAP NAS devices have a microcontroller controlling the main power > supply. This microcontroller is connected to UART1 of the Kirkwood and > Orion5x SoCs. Sending the character 'A', at 19200 baud, tells the > -microcontroller to turn the power off. This driver adds a handler to > -pm_power_off which is called to turn the power off. > +microcontroller to turn the power off. This driver installs a handler > +to power off the system. I'd remove the last sentence -- the driver is also independent of the HW, and the description of how the power off works at the HW level is sufficient. With that: Acked-by: Mark Rutland Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH 07/44] qnap-poweroff: Drop reference to pm_power_off from devicetree bindings Date: Tue, 7 Oct 2014 12:02:19 +0100 Message-ID: <20141007110219.GE24725@leverpostej> References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-8-git-send-email-linux@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:53263 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753633AbaJGLC3 (ORCPT ); Tue, 7 Oct 2014 07:02:29 -0400 Content-Disposition: inline In-Reply-To: <1412659726-29957-8-git-send-email-linux@roeck-us.net> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Guenter Roeck Cc: "linux-kernel@vger.kernel.org" , "adi-buildroot-devel@lists.sourceforge.net" , "devel@driverdev.osuosl.org" , "devicetree@vger.kernel.org" , "lguest@lists.ozlabs.org" , "linux-acpi@vger.kernel.org" , "linux-alpha@vger.kernel.org" , "linux-am33-list@redhat.com" , "linux-cris-kernel@axis.com" , "linux-efi@vger.kernel.org" , "linux-hexagon@vger.kernel.org" , "linux-m32r-ja@ml.linux-m32r.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-s390@vger.kernel.org" lin On Tue, Oct 07, 2014 at 06:28:09AM +0100, Guenter Roeck wrote: > Replace reference to pm_power_off (which is an implementation detail) > and replace it with a more generic description of the driver's functionality. > > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Signed-off-by: Guenter Roeck > --- > Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt b/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > index af25e77..1e2260a 100644 > --- a/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > +++ b/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > @@ -3,8 +3,8 @@ > QNAP NAS devices have a microcontroller controlling the main power > supply. This microcontroller is connected to UART1 of the Kirkwood and > Orion5x SoCs. Sending the character 'A', at 19200 baud, tells the > -microcontroller to turn the power off. This driver adds a handler to > -pm_power_off which is called to turn the power off. > +microcontroller to turn the power off. This driver installs a handler > +to power off the system. I'd remove the last sentence -- the driver is also independent of the HW, and the description of how the power off works at the HW level is sufficient. With that: Acked-by: Mark Rutland Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Date: Tue, 07 Oct 2014 11:02:19 +0000 Subject: Re: [PATCH 07/44] qnap-poweroff: Drop reference to pm_power_off from devicetree bindings Message-Id: <20141007110219.GE24725@leverpostej> List-Id: References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-8-git-send-email-linux@roeck-us.net> In-Reply-To: <1412659726-29957-8-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Guenter Roeck Cc: "linux-kernel@vger.kernel.org" , "adi-buildroot-devel@lists.sourceforge.net" , "devel@driverdev.osuosl.org" , "devicetree@vger.kernel.org" , "lguest@lists.ozlabs.org" , "linux-acpi@vger.kernel.org" , "linux-alpha@vger.kernel.org" , "linux-am33-list@redhat.com" , "linux-cris-kernel@axis.com" , "linux-efi@vger.kernel.org" , "linux-hexagon@vger.kernel.org" , "linux-m32r-ja@ml.linux-m32r.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-s390@vger.kernel.org" On Tue, Oct 07, 2014 at 06:28:09AM +0100, Guenter Roeck wrote: > Replace reference to pm_power_off (which is an implementation detail) > and replace it with a more generic description of the driver's functionality. > > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Signed-off-by: Guenter Roeck > --- > Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt b/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > index af25e77..1e2260a 100644 > --- a/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > +++ b/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > @@ -3,8 +3,8 @@ > QNAP NAS devices have a microcontroller controlling the main power > supply. This microcontroller is connected to UART1 of the Kirkwood and > Orion5x SoCs. Sending the character 'A', at 19200 baud, tells the > -microcontroller to turn the power off. This driver adds a handler to > -pm_power_off which is called to turn the power off. > +microcontroller to turn the power off. This driver installs a handler > +to power off the system. I'd remove the last sentence -- the driver is also independent of the HW, and the description of how the power off works at the HW level is sufficient. With that: Acked-by: Mark Rutland Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 07 Oct 2014 13:02:48 +0200 (CEST) Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:53281 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27010703AbaJGLCql3fdP (ORCPT ); Tue, 7 Oct 2014 13:02:46 +0200 Received: from leverpostej (leverpostej.cambridge.arm.com [10.1.205.151]) by cam-admin0.cambridge.arm.com (8.12.6/8.12.6) with ESMTP id s97B2Nwo019071; Tue, 7 Oct 2014 12:02:23 +0100 (BST) Date: Tue, 7 Oct 2014 12:02:19 +0100 From: Mark Rutland To: Guenter Roeck Cc: "linux-kernel@vger.kernel.org" , "adi-buildroot-devel@lists.sourceforge.net" , "devel@driverdev.osuosl.org" , "devicetree@vger.kernel.org" , "lguest@lists.ozlabs.org" , "linux-acpi@vger.kernel.org" , "linux-alpha@vger.kernel.org" , "linux-am33-list@redhat.com" , "linux-cris-kernel@axis.com" , "linux-efi@vger.kernel.org" , "linux-hexagon@vger.kernel.org" , "linux-m32r-ja@ml.linux-m32r.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-s390@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-xtensa@linux-xtensa.org" , "openipmi-developer@lists.sourceforge.net" , "user-mode-linux-devel@lists.sourceforge.net" , "linux-arm-kernel@lists.infradead.org" , "linux-c6x-dev@linux-c6x.org" , "linux-ia64@vger.kernel.org" , "linux-m68k@vger.kernel.org" , "linux-metag@vger.kernel.org" , "linux-mips@linux-mips.org" , "linux-parisc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-sh@vger.kernel.org" , "xen-devel@lists.xenproject.org" , Rob Herring , Pawel Moll Subject: Re: [PATCH 07/44] qnap-poweroff: Drop reference to pm_power_off from devicetree bindings Message-ID: <20141007110219.GE24725@leverpostej> References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-8-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1412659726-29957-8-git-send-email-linux@roeck-us.net> User-Agent: Mutt/1.5.21 (2010-09-15) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 43049 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: mark.rutland@arm.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Tue, Oct 07, 2014 at 06:28:09AM +0100, Guenter Roeck wrote: > Replace reference to pm_power_off (which is an implementation detail) > and replace it with a more generic description of the driver's functionality. > > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Signed-off-by: Guenter Roeck > --- > Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt b/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > index af25e77..1e2260a 100644 > --- a/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > +++ b/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > @@ -3,8 +3,8 @@ > QNAP NAS devices have a microcontroller controlling the main power > supply. This microcontroller is connected to UART1 of the Kirkwood and > Orion5x SoCs. Sending the character 'A', at 19200 baud, tells the > -microcontroller to turn the power off. This driver adds a handler to > -pm_power_off which is called to turn the power off. > +microcontroller to turn the power off. This driver installs a handler > +to power off the system. I'd remove the last sentence -- the driver is also independent of the HW, and the description of how the power off works at the HW level is sufficient. With that: Acked-by: Mark Rutland Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH 07/44] qnap-poweroff: Drop reference to pm_power_off from devicetree bindings Date: Tue, 7 Oct 2014 12:02:19 +0100 Message-ID: <20141007110219.GE24725@leverpostej> References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-8-git-send-email-linux@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1412659726-29957-8-git-send-email-linux@roeck-us.net> Sender: linux-acpi-owner@vger.kernel.org List-Archive: List-Post: To: Guenter Roeck Cc: "linux-kernel@vger.kernel.org" , "adi-buildroot-devel@lists.sourceforge.net" , "devel@driverdev.osuosl.org" , "devicetree@vger.kernel.org" , "lguest@lists.ozlabs.org" , "linux-acpi@vger.kernel.org" , "linux-alpha@vger.kernel.org" , "linux-am33-list@redhat.com" , "linux-cris-kernel@axis.com" , "linux-efi@vger.kernel.org" , "linux-hexagon@vger.kernel.org" , "linux-m32r-ja@ml.linux-m32r.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-s390@vger.kernel.org" List-ID: On Tue, Oct 07, 2014 at 06:28:09AM +0100, Guenter Roeck wrote: > Replace reference to pm_power_off (which is an implementation detail) > and replace it with a more generic description of the driver's functionality. > > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Signed-off-by: Guenter Roeck > --- > Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt b/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > index af25e77..1e2260a 100644 > --- a/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > +++ b/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > @@ -3,8 +3,8 @@ > QNAP NAS devices have a microcontroller controlling the main power > supply. This microcontroller is connected to UART1 of the Kirkwood and > Orion5x SoCs. Sending the character 'A', at 19200 baud, tells the > -microcontroller to turn the power off. This driver adds a handler to > -pm_power_off which is called to turn the power off. > +microcontroller to turn the power off. This driver installs a handler > +to power off the system. I'd remove the last sentence -- the driver is also independent of the HW, and the description of how the power off works at the HW level is sufficient. With that: Acked-by: Mark Rutland Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cam-admin0.cambridge.arm.com (cam-admin0.cambridge.arm.com [217.140.96.50]) by lists.ozlabs.org (Postfix) with ESMTP id 8FFFD1A1C08 for ; Tue, 7 Oct 2014 22:03:13 +1100 (EST) Date: Tue, 7 Oct 2014 12:02:19 +0100 From: Mark Rutland To: Guenter Roeck Subject: Re: [PATCH 07/44] qnap-poweroff: Drop reference to pm_power_off from devicetree bindings Message-ID: <20141007110219.GE24725@leverpostej> References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-8-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1412659726-29957-8-git-send-email-linux@roeck-us.net> Cc: "linux-m32r-ja@ml.linux-m32r.org" , "linux-mips@linux-mips.org" , "linux-m68k@vger.kernel.org" , "linux-efi@vger.kernel.org" , "linux-ia64@vger.kernel.org" , "linux-xtensa@linux-xtensa.org" , "devel@driverdev.osuosl.org" , "linux-s390@vger.kernel.org" , "lguest@lists.ozlabs.org" , "linux-c6x-dev@linux-c6x.org" , "linux-hexagon@vger.kernel.org" , "linux-sh@vger.kernel.org" , "linux-acpi@vger.kernel.org" , Pawel Moll , "xen-devel@lists.xenproject.org" , "devicetree@vger.kernel.org" , "user-mode-linux-devel@lists.sourceforge.net" , "linux-pm@vger.kernel.org" , "adi-buildroot-devel@lists.sourceforge.net" , "linux-am33-list@redhat.com" , "linux-tegra@vger.kernel.org" , "openipmi-developer@lists.sourceforge.net" , "linux-metag@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-parisc@vger.kernel.org" , "linux-cris-kernel@axis.com" , "linux-kernel@vger.kernel.org" , Rob Herring , "linux-alpha@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Oct 07, 2014 at 06:28:09AM +0100, Guenter Roeck wrote: > Replace reference to pm_power_off (which is an implementation detail) > and replace it with a more generic description of the driver's functionality. > > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Signed-off-by: Guenter Roeck > --- > Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt b/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > index af25e77..1e2260a 100644 > --- a/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > +++ b/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > @@ -3,8 +3,8 @@ > QNAP NAS devices have a microcontroller controlling the main power > supply. This microcontroller is connected to UART1 of the Kirkwood and > Orion5x SoCs. Sending the character 'A', at 19200 baud, tells the > -microcontroller to turn the power off. This driver adds a handler to > -pm_power_off which is called to turn the power off. > +microcontroller to turn the power off. This driver installs a handler > +to power off the system. I'd remove the last sentence -- the driver is also independent of the HW, and the description of how the power off works at the HW level is sufficient. With that: Acked-by: Mark Rutland Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.rutland@arm.com (Mark Rutland) Date: Tue, 7 Oct 2014 12:02:19 +0100 Subject: [PATCH 07/44] qnap-poweroff: Drop reference to pm_power_off from devicetree bindings In-Reply-To: <1412659726-29957-8-git-send-email-linux@roeck-us.net> References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-8-git-send-email-linux@roeck-us.net> Message-ID: <20141007110219.GE24725@leverpostej> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Oct 07, 2014 at 06:28:09AM +0100, Guenter Roeck wrote: > Replace reference to pm_power_off (which is an implementation detail) > and replace it with a more generic description of the driver's functionality. > > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Signed-off-by: Guenter Roeck > --- > Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt b/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > index af25e77..1e2260a 100644 > --- a/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > +++ b/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > @@ -3,8 +3,8 @@ > QNAP NAS devices have a microcontroller controlling the main power > supply. This microcontroller is connected to UART1 of the Kirkwood and > Orion5x SoCs. Sending the character 'A', at 19200 baud, tells the > -microcontroller to turn the power off. This driver adds a handler to > -pm_power_off which is called to turn the power off. > +microcontroller to turn the power off. This driver installs a handler > +to power off the system. I'd remove the last sentence -- the driver is also independent of the HW, and the description of how the power off works at the HW level is sufficient. With that: Acked-by: Mark Rutland Thanks, Mark.