All of lore.kernel.org
 help / color / mirror / Atom feed
From: pavel@denx.de (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] socfpga: support suspend to ram
Date: Tue, 7 Oct 2014 13:17:15 +0200	[thread overview]
Message-ID: <20141007111715.GB6904@amd> (raw)
In-Reply-To: <1412192304-1209-3-git-send-email-atull@opensource.altera.com>

Hi!

> From: Alan Tull <atull@opensource.altera.com>
> 
> Add code that requests that the sdr controller go into
> self-refresh mode.  This code is run from ocram.
> 
> This patch assumes that u-boot has already configured sdr:
>   sdr.ctrlcfg.lowpwreq.selfrfshmask = 3
>   sdr.ctrlcfg.lowpwrtiming.clkdisablecycles = 8
>   sdr.ctrlcfg.dramtiming4.selfrfshexit = 512
> 
> How to suspend to ram:
>  $ echo enabled > \
> /sys/devices/soc/ffc02000.serial0/tty/ttyS0/power/wakeup
> 
>  $ echo -n mem > /sys/power/state
> 
> Signed-off-by: Alan Tull <atull@opensource.altera.com>

> +static int __init socfpga_pm_init(void)
> +{
> +	if (socfpga_setup_ocram_self_refresh())
> +		return -EFAULT;

It would be nice to propagate the error result here.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@denx.de>
To: atull@opensource.altera.com
Cc: dinguyen@opensource.altera.com, linux@arm.linux.org.uk,
	yvanderv@opensource.altera.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, delicious.quinoa@gmail.com
Subject: Re: [PATCH v2 2/2] socfpga: support suspend to ram
Date: Tue, 7 Oct 2014 13:17:15 +0200	[thread overview]
Message-ID: <20141007111715.GB6904@amd> (raw)
In-Reply-To: <1412192304-1209-3-git-send-email-atull@opensource.altera.com>

Hi!

> From: Alan Tull <atull@opensource.altera.com>
> 
> Add code that requests that the sdr controller go into
> self-refresh mode.  This code is run from ocram.
> 
> This patch assumes that u-boot has already configured sdr:
>   sdr.ctrlcfg.lowpwreq.selfrfshmask = 3
>   sdr.ctrlcfg.lowpwrtiming.clkdisablecycles = 8
>   sdr.ctrlcfg.dramtiming4.selfrfshexit = 512
> 
> How to suspend to ram:
>  $ echo enabled > \
> /sys/devices/soc/ffc02000.serial0/tty/ttyS0/power/wakeup
> 
>  $ echo -n mem > /sys/power/state
> 
> Signed-off-by: Alan Tull <atull@opensource.altera.com>

> +static int __init socfpga_pm_init(void)
> +{
> +	if (socfpga_setup_ocram_self_refresh())
> +		return -EFAULT;

It would be nice to propagate the error result here.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2014-10-07 11:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-01 19:38 [PATCH v2 0/2] socfpga: fix hotplug/add suspend to ram atull at opensource.altera.com
2014-10-01 19:38 ` atull
2014-10-01 19:38 ` [PATCH v2 1/2] socfpga: hotplug: put cpu1 in wfi atull at opensource.altera.com
2014-10-01 19:38   ` atull
2014-10-07 11:10   ` Pavel Machek
2014-10-07 11:10     ` Pavel Machek
2014-10-07 14:19     ` atull
2014-10-07 14:19       ` atull
2014-10-01 19:38 ` [PATCH v2 2/2] socfpga: support suspend to ram atull at opensource.altera.com
2014-10-01 19:38   ` atull
2014-10-02 21:16   ` atull
2014-10-02 21:16     ` atull
2014-10-07 11:17   ` Pavel Machek [this message]
2014-10-07 11:17     ` Pavel Machek
2014-10-07 14:17     ` atull
2014-10-07 14:17       ` atull

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141007111715.GB6904@amd \
    --to=pavel@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.