Re: [meta-oe][PATCHv2] modphp, xdebug: blacklist because of conflict with php

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2780 bytes --]

On Tue, Oct 07, 2014 at 09:39:34AM +0100, Paul Eggleton wrote:
> On Tuesday 07 October 2014 06:53:17 Martin Jansa wrote:
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> >  meta-webserver/recipes-php/modphp/modphp5.inc     | 3 +++
> >  meta-webserver/recipes-php/xdebug/xdebug_2.2.5.bb | 1 +
> >  2 files changed, 4 insertions(+)
> > 
> > diff --git a/meta-webserver/recipes-php/modphp/modphp5.inc
> > b/meta-webserver/recipes-php/modphp/modphp5.inc index 6932429..8707950
> > 100644
> > --- a/meta-webserver/recipes-php/modphp/modphp5.inc
> > +++ b/meta-webserver/recipes-php/modphp/modphp5.inc
> > @@ -14,6 +14,9 @@ S = "${WORKDIR}/php-${PV}"
> > 
> >  LIC_FILES_CHKSUM = "file://LICENSE;md5=52dd90569008fee5bcdbb22d945b1108"
> > 
> > +PNBLACKLIST[modphp] = "CONFLICT: 466 header files conflict with php"
> > +# e.g. sysroots/qemux86-64/usr/include/php/main/win95nt.h
> > +
> 
> I'm sorry, but we are not going to blacklist this recipe for everyone. I 
> appreciate that stricter tests mean these can't be built side-by-side, that's 
> just unfortunate and something we will have to live with for now.

It was motivated by discussion with RP and Ross on #yocto.

23:52:26 < JaMa|Off> RP: would it make sense to change populate-sysroot conflicts to use package_qa_handle_error function so it would be fatal QA error (by default) with option to disable it?
23:53:31 < JaMa|Off> RP: I think part of this problem was that normal bb.warn messages are less visible than QA messages (which are also collected in qa.log) so easy to check after the build
23:55:49 < RP> JaMa|Off: To be honest, I don't want people to turn that on off. The issues are too nasty
23:56:42 < RP> s/on/one/
23:56:46 < JaMa|Off> OK, fair enough, I agree it's nasty
23:57:32 < JaMa|Off> it's last 6 failures in world builds (after including all my pending fixes), I've sent the list earlier today
23:57:45 < RP> JaMa|Off: if it stops there and then, the issue can usually be recovered. If you continue past that you no longer know what in the sysroot is corrupted
23:58:47 < JaMa|Off> the problem is that if I go with PNBLACKLIST (to blacklist one from the conflicting duo) then I'm blacklisting something which alone is fine (unless you're building the other 
                     recipe as well)
23:59:41 < JaMa|Off> e.g. Paul won't be happy if I blacklist modphp, just because it conflicts with php and vice-versa
00:20:27 < rburton> JaMa|Off: blacklisting both php and modphp is clearly the answer, and improves the world
00:22:43 < JaMa|Off> should I send patch for oe-core to blacklist xz and lzma as well? :)

You can still disable that PNBLACKLIST in your local.conf or distro.conf.
-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]