From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XbYx9-0004st-5c for kexec@lists.infradead.org; Tue, 07 Oct 2014 17:53:39 +0000 Date: Tue, 7 Oct 2014 13:52:48 -0400 From: Vivek Goyal Subject: Re: [PATCH V25/5] powerpc/kexec: Use global IND_FLAGS macro Message-ID: <20141007175248.GG27464@redhat.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Geoff Levand Cc: Benjamin Herrenschmidt , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Eric Biederman , Andrew Morton , linuxppc-dev@lists.ozlabs.org On Tue, Oct 07, 2014 at 12:21:30AM +0000, Geoff Levand wrote: > linux/kexec.h now defines an IND_FLAGS macro. Remove the local powerpc > definition and use the generic one. > > Signed-off-by: Geoff Levand I think this patch should be merged in previous patch. I guess after applying patch4, series might not be compilable as there are two definitions of IND_FLAGS now. Thanks Vivek > --- > arch/powerpc/kernel/machine_kexec_64.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/powerpc/kernel/machine_kexec_64.c b/arch/powerpc/kernel/machine_kexec_64.c > index 879b3aa..75652a32 100644 > --- a/arch/powerpc/kernel/machine_kexec_64.c > +++ b/arch/powerpc/kernel/machine_kexec_64.c > @@ -96,8 +96,6 @@ int default_machine_kexec_prepare(struct kimage *image) > return 0; > } > > -#define IND_FLAGS (IND_DESTINATION | IND_INDIRECTION | IND_DONE | IND_SOURCE) > - > static void copy_segments(unsigned long ind) > { > unsigned long entry; > -- > 1.9.1 > > > _______________________________________________ > kexec mailing list > kexec@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 1E9A11A078A for ; Wed, 8 Oct 2014 04:53:41 +1100 (EST) Date: Tue, 7 Oct 2014 13:52:48 -0400 From: Vivek Goyal To: Geoff Levand Subject: Re: [PATCH V25/5] powerpc/kexec: Use global IND_FLAGS macro Message-ID: <20141007175248.GG27464@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Eric Biederman , Andrew Morton , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Oct 07, 2014 at 12:21:30AM +0000, Geoff Levand wrote: > linux/kexec.h now defines an IND_FLAGS macro. Remove the local powerpc > definition and use the generic one. > > Signed-off-by: Geoff Levand I think this patch should be merged in previous patch. I guess after applying patch4, series might not be compilable as there are two definitions of IND_FLAGS now. Thanks Vivek > --- > arch/powerpc/kernel/machine_kexec_64.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/powerpc/kernel/machine_kexec_64.c b/arch/powerpc/kernel/machine_kexec_64.c > index 879b3aa..75652a32 100644 > --- a/arch/powerpc/kernel/machine_kexec_64.c > +++ b/arch/powerpc/kernel/machine_kexec_64.c > @@ -96,8 +96,6 @@ int default_machine_kexec_prepare(struct kimage *image) > return 0; > } > > -#define IND_FLAGS (IND_DESTINATION | IND_INDIRECTION | IND_DONE | IND_SOURCE) > - > static void copy_segments(unsigned long ind) > { > unsigned long entry; > -- > 1.9.1 > > > _______________________________________________ > kexec mailing list > kexec@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932093AbaJGRxo (ORCPT ); Tue, 7 Oct 2014 13:53:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27416 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755062AbaJGRxm (ORCPT ); Tue, 7 Oct 2014 13:53:42 -0400 Date: Tue, 7 Oct 2014 13:52:48 -0400 From: Vivek Goyal To: Geoff Levand Cc: Andrew Morton , Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, kexec@lists.infradead.org, Eric Biederman , linux-kernel@vger.kernel.org Subject: Re: [PATCH V25/5] powerpc/kexec: Use global IND_FLAGS macro Message-ID: <20141007175248.GG27464@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 07, 2014 at 12:21:30AM +0000, Geoff Levand wrote: > linux/kexec.h now defines an IND_FLAGS macro. Remove the local powerpc > definition and use the generic one. > > Signed-off-by: Geoff Levand I think this patch should be merged in previous patch. I guess after applying patch4, series might not be compilable as there are two definitions of IND_FLAGS now. Thanks Vivek > --- > arch/powerpc/kernel/machine_kexec_64.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/powerpc/kernel/machine_kexec_64.c b/arch/powerpc/kernel/machine_kexec_64.c > index 879b3aa..75652a32 100644 > --- a/arch/powerpc/kernel/machine_kexec_64.c > +++ b/arch/powerpc/kernel/machine_kexec_64.c > @@ -96,8 +96,6 @@ int default_machine_kexec_prepare(struct kimage *image) > return 0; > } > > -#define IND_FLAGS (IND_DESTINATION | IND_INDIRECTION | IND_DONE | IND_SOURCE) > - > static void copy_segments(unsigned long ind) > { > unsigned long entry; > -- > 1.9.1 > > > _______________________________________________ > kexec mailing list > kexec@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec