From: Mark Brown <broonie@kernel.org>
To: Chris Zhong <zyw@rock-chips.com>
Cc: dianders@chromium.org, heiko@sntech.de,
linux-rockchip@lists.infradead.org,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: rk808: Add support setting suspend voltage
Date: Tue, 7 Oct 2014 19:13:49 +0100 [thread overview]
Message-ID: <20141007181349.GV4609@sirena.org.uk> (raw)
In-Reply-To: <1412671438-25399-1-git-send-email-zyw@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 477 bytes --]
On Tue, Oct 07, 2014 at 04:43:57PM +0800, Chris Zhong wrote:
> @@ -100,6 +132,8 @@ static struct regulator_ops rk808_buck1_2_ops = {
> .disable = regulator_disable_regmap,
> .is_enabled = regulator_is_enabled_regmap,
> .set_ramp_delay = rk808_set_ramp_delay,
> + .set_suspend_voltage = rk808_set_suspend_voltage,
> + .set_suspend_disable = rk808_set_suspend_disable,
> };
Why are there only disable operations, no enable ones? Otherwise this
all looks good.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-10-07 18:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 8:43 [PATCH] regulator: rk808: Add support setting suspend voltage Chris Zhong
2014-10-07 17:48 ` Doug Anderson
2014-10-08 8:46 ` Javier Martinez Canillas
2014-10-08 16:30 ` Doug Anderson
2014-10-08 12:49 ` Mark Brown
2014-10-08 16:12 ` Doug Anderson
2014-10-08 18:19 ` Mark Brown
2014-10-07 18:13 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007181349.GV4609@sirena.org.uk \
--to=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.