From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolin Chen <nicoleotsuka@gmail.com>
Subject: Re: [PATCH 1/2] ASoC: fsl: imx-wm8962: Delete unneeded
 test before of_node_put
Date: Tue, 7 Oct 2014 11:18:10 -0700
Message-ID: <20141007181810.GC2796@Alpha>
References: <1412705605-13646-1-git-send-email-fabio.estevam@freescale.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com
 [209.85.220.42])
 by alsa0.perex.cz (Postfix) with ESMTP id A562E2606AD
 for <alsa-devel@alsa-project.org>; Tue,  7 Oct 2014 20:18:14 +0200 (CEST)
Received: by mail-pa0-f42.google.com with SMTP id bj1so7650375pad.29
 for <alsa-devel@alsa-project.org>; Tue, 07 Oct 2014 11:18:13 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1412705605-13646-1-git-send-email-fabio.estevam@freescale.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Fabio Estevam <fabio.estevam@freescale.com>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org
List-Id: alsa-devel@alsa-project.org

On Tue, Oct 07, 2014 at 03:13:24PM -0300, Fabio Estevam wrote:
> of_node_put() supports NULL as its argument, so the initial test is not
> necessary.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

For both two patches:

Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>

Thank you
Nic

> ---
>  sound/soc/fsl/imx-wm8962.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/soc/fsl/imx-wm8962.c b/sound/soc/fsl/imx-wm8962.c
> index 3a3d17c..48179ff 100644
> --- a/sound/soc/fsl/imx-wm8962.c
> +++ b/sound/soc/fsl/imx-wm8962.c
> @@ -281,10 +281,8 @@ static int imx_wm8962_probe(struct platform_device *pdev)
>  clk_fail:
>  	clk_disable_unprepare(data->codec_clk);
>  fail:
> -	if (ssi_np)
> -		of_node_put(ssi_np);
> -	if (codec_np)
> -		of_node_put(codec_np);
> +	of_node_put(ssi_np);
> +	of_node_put(codec_np);
>  
>  	return ret;
>  }
> -- 
> 1.9.1
>