All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Fabio Estevam <fabio.estevam@freescale.com>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org
Subject: Re: [PATCH 2/4] ASoC: fsl: imx-spdif: Delete unneeded test before of_node_put
Date: Tue, 7 Oct 2014 11:42:03 -0700	[thread overview]
Message-ID: <20141007184202.GA12286@Alpha> (raw)
In-Reply-To: <1412706598-18796-2-git-send-email-fabio.estevam@freescale.com>

On Tue, Oct 07, 2014 at 03:29:56PM -0300, Fabio Estevam wrote:
> of_node_put() supports NULL as its argument, so the initial test is not
> necessary.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Acked for two fsl ones.

Thank you again
Nicolin

> ---
>  sound/soc/fsl/imx-spdif.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/sound/soc/fsl/imx-spdif.c b/sound/soc/fsl/imx-spdif.c
> index e1dc401..0c9068e 100644
> --- a/sound/soc/fsl/imx-spdif.c
> +++ b/sound/soc/fsl/imx-spdif.c
> @@ -74,8 +74,7 @@ static int imx_spdif_audio_probe(struct platform_device *pdev)
>  	platform_set_drvdata(pdev, data);
>  
>  end:
> -	if (spdif_np)
> -		of_node_put(spdif_np);
> +	of_node_put(spdif_np);
>  
>  	return ret;
>  }
> -- 
> 1.9.1
> 

  reply	other threads:[~2014-10-07 18:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-07 18:29 [PATCH 1/4] ASoC: mc13783: Delete unneeded test before of_node_put Fabio Estevam
2014-10-07 18:29 ` [PATCH 2/4] ASoC: fsl: imx-spdif: " Fabio Estevam
2014-10-07 18:42   ` Nicolin Chen [this message]
2014-10-07 19:01   ` Mark Brown
2014-10-07 18:29 ` [PATCH 3/4] ASoC: fsl: eukrea-tlv320: " Fabio Estevam
2014-10-07 19:01   ` Mark Brown
2014-10-07 18:29 ` [PATCH 4/4] ASoC: simple-card: " Fabio Estevam
2014-10-07 19:02   ` Mark Brown
2014-10-07 18:59 ` [PATCH 1/4] ASoC: mc13783: " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141007184202.GA12286@Alpha \
    --to=nicoleotsuka@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=fabio.estevam@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.