From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 36D96E007C1; Tue, 7 Oct 2014 12:16:54 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high * trust * [198.47.26.152 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id C254EE0076C for ; Tue, 7 Oct 2014 12:16:49 -0700 (PDT) Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id s97JGmPc031348 for ; Tue, 7 Oct 2014 14:16:48 -0500 Received: from DLEE70.ent.ti.com (dlemailx.itg.ti.com [157.170.170.113]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s97JGmtB030806 for ; Tue, 7 Oct 2014 14:16:48 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.3.174.1; Tue, 7 Oct 2014 14:16:47 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s97JGlD5026447; Tue, 7 Oct 2014 14:16:47 -0500 Date: Tue, 7 Oct 2014 15:16:47 -0400 From: Denys Dmytriyenko To: Karthik Ramanan Message-ID: <20141007191647.GD1731@edge> References: <1411559009-7951-2-git-send-email-a0393906@ti.com> <1412142291-11850-1-git-send-email-a0393906@ti.com> MIME-Version: 1.0 In-Reply-To: <1412142291-11850-1-git-send-email-a0393906@ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: meta-ti@yoctoproject.org Subject: Re: [PATCH v2] dspdce-fw: Updated dspdce firmware for latest IPC version X-BeenThere: meta-ti@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-ti layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Oct 2014 19:16:54 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Karthik, I'm at lost here. You did address my previous comment of not leaving 2 versions, just updating from .02 to .04, but I don't understand why do you need an .inc file for, if there's only one version left? I traced it a bit back and there was a recommendation from Franklin about creating .inc file for a different recipe for ipumm-fw, but in that case it is warranted due to the fact that you pull 2 different sources for 2 platforms. So, in that case it might be better having 2 separate recipes for different machines with common parts in the .inc file, but see for yourself if that produces cleaner and simpler results. It's not alwats clear cut and you may need to experiment to choose the right option... Either way, dspdce-fw doesn't seem to need an .inc file. -- Denys On Wed, Oct 01, 2014 at 11:14:51AM +0530, Karthik Ramanan wrote: > Also refactored the dspdce-fw recipes to have inc file > for common parts > > Signed-off-by: Karthik Ramanan > --- > recipes-bsp/dspdce-fw/dspdce-fw.inc | 18 ++++++++++++++++++ > recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb | 24 ------------------------ > recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb | 11 +++++++++++ > 3 files changed, 29 insertions(+), 24 deletions(-) > create mode 100644 recipes-bsp/dspdce-fw/dspdce-fw.inc > delete mode 100644 recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb > create mode 100644 recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb > > diff --git a/recipes-bsp/dspdce-fw/dspdce-fw.inc b/recipes-bsp/dspdce-fw/dspdce-fw.inc > new file mode 100644 > index 0000000..9676888 > --- /dev/null > +++ b/recipes-bsp/dspdce-fw/dspdce-fw.inc > @@ -0,0 +1,18 @@ > +DESCRIPTION = "Firmware for DSP for an example application called copycodectest" > +LICENSE = "TI-TSPA" > + > +COMPATIBLE_MACHINE = "dra7xx-evm" > +PACKAGE_ARCH = "${MACHINE_ARCH}" > + > +S = "${WORKDIR}/dspdce-${MACHINE}-${PV}" > + > +TARGET = "dra7-dsp1-fw.xe66" > + > +do_install() { > + mkdir -p ${D}${base_libdir}/firmware > + cp ${S}/firmware/${TARGET} ${D}${base_libdir}/firmware/${TARGET} > +} > + > +FILES_${PN} += "${base_libdir}/firmware/${TARGET}" > + > +INSANE_SKIP_${PN} = "arch" > diff --git a/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb b/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb > deleted file mode 100644 > index 69e9814..0000000 > --- a/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb > +++ /dev/null > @@ -1,24 +0,0 @@ > -DESCRIPTION = "Firmware for DSP " > -LICENSE = "TI-TSPA" > -LIC_FILES_CHKSUM = "file://DSPDCE-${PV}-Manifest.doc;md5=587a7b9fdd99f98fbe99af4a4ba3362a" > - > -COMPATIBLE_MACHINE = "dra7xx-evm" > -PACKAGE_ARCH = "${MACHINE_ARCH}" > - > -SRC_URI = "http://downloads.ti.com/dsps/dsps_public_sw/glsdk/dspdce/1_00_00_02/exports/dspdce-${MACHINE}-1.00.00.02.tar.gz;protocol=http" > - > -S = "${WORKDIR}/dspdce-${MACHINE}-${PV}" > - > -SRC_URI[md5sum] = "df19baf16f828b5d32b4eed50f0364f5" > -SRC_URI[sha256sum] = "0c0f34674110d1ef0300b61b572a326daffb95a31cc9d45888b2e50a83c6f555" > - > -TARGET = "dra7-dsp1-fw.xe66" > - > -do_install() { > - mkdir -p ${D}${base_libdir}/firmware > - cp ${S}/firmware/${TARGET} ${D}${base_libdir}/firmware/${TARGET} > -} > - > -FILES_${PN} += "${base_libdir}/firmware/${TARGET}" > - > -INSANE_SKIP_${PN} = "arch" > diff --git a/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb b/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb > new file mode 100644 > index 0000000..db01f31 > --- /dev/null > +++ b/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb > @@ -0,0 +1,11 @@ > +require dspdce-fw.inc > + > +LIC_FILES_CHKSUM = "file://DSPDCE-${PV}-Manifest.doc;md5=b8feda5a3ed8197d05993c0d0ff5590e" > + > +PR = "r0" > + > +SRC_URI = " http://downloads.ti.com/dsps/dsps_public_sw/glsdk/dspdce/1_00_00_04/exports/dspdce-${MACHINE}-1.00.00.04.tar.gz;protocol=ftp" > + > +SRC_URI[md5sum] = "72722b12e90c26a85f7f1b56d749cad0" > +SRC_URI[sha256sum] = "64057db41dbee5a992db88129a9154f27c67cfbba8efdc0f09b7de38df4d58eb" > + > -- > 1.7.9.5 > > -- > _______________________________________________ > meta-ti mailing list > meta-ti@yoctoproject.org > https://lists.yoctoproject.org/listinfo/meta-ti