Re: [PATCH 06/11] perf: Move cgroup init before PMU ->event_init()

[Peter Zijlstra <peterz@infradead.org>]

On Wed, Oct 08, 2014 at 11:32:50AM +0100, Matt Fleming wrote:
> On Tue, 07 Oct, at 09:34:24PM, Peter Zijlstra wrote:
> > On Wed, Sep 24, 2014 at 03:04:10PM +0100, Matt Fleming wrote:
> > > +++ b/kernel/events/core.c
> > > @@ -6859,7 +6859,7 @@ perf_event_alloc(struct perf_event_attr *attr, int cpu,
> > >  		 struct perf_event *group_leader,
> > >  		 struct perf_event *parent_event,
> > >  		 perf_overflow_handler_t overflow_handler,
> > > -		 void *context)
> > > +		 void *context, bool cgroup, pid_t pid)
> > >  {
> > >  	struct pmu *pmu;
> > >  	struct perf_event *event;
> > 
> > I don't get this extension, why a bool and pid_t ?
> 
> So that it's possible to figure out whether we need to call
> perf_cgroup_connect(). 
> 
> Oh, why not just 'int fd', you mean? Ermm... yeah that would be better.

Jah ;-)