From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vc0-f176.google.com ([209.85.220.176]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XbopD-0006Hd-T7 for linux-mtd@lists.infradead.org; Wed, 08 Oct 2014 10:50:32 +0000 Received: by mail-vc0-f176.google.com with SMTP id hq11so6393409vcb.35 for ; Wed, 08 Oct 2014 03:50:10 -0700 (PDT) Date: Wed, 8 Oct 2014 11:50:05 +0100 From: Lee Jones To: Brian Norris Subject: Re: [PATCH 8/9] mtd: nand: stm_nand_bch: add support for ST's BCH NAND controller Message-ID: <20141008105005.GH20647@lee--X1> References: <1409143344-22458-1-git-send-email-lee.jones@linaro.org> <1409143344-22458-9-git-send-email-lee.jones@linaro.org> <20141006064030.GA20598@norris-Latitude-E6410> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20141006064030.GA20598@norris-Latitude-E6410> Cc: pekon@pek-sem.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@stlinux.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, 05 Oct 2014, Brian Norris wrote: > On Wed, Aug 27, 2014 at 01:42:23PM +0100, Lee Jones wrote: > > Reviewed-By: Pekon Gupta > > Signed-off-by: Lee Jones > > --- > > drivers/mtd/nand/Kconfig | 7 + > > drivers/mtd/nand/Makefile | 1 + > > drivers/mtd/nand/stm_nand_bch.c | 1616 +++++++++++++++++++++++++++++++++++++++ > > drivers/mtd/nand/stm_nand_dt.c | 110 +++ > > drivers/mtd/nand/stm_nand_dt.h | 24 + > > include/linux/mtd/stm_nand.h | 147 ++++ > > 6 files changed, 1905 insertions(+) > > create mode 100644 drivers/mtd/nand/stm_nand_bch.c > > create mode 100644 drivers/mtd/nand/stm_nand_dt.c > > create mode 100644 drivers/mtd/nand/stm_nand_dt.h > > create mode 100644 include/linux/mtd/stm_nand.h > > One more thing: you never answered my question from [1]: > > Does your driver pass the MTD tests? (drivers/mtd/tests/) It does. Apart from the ones which insist on reading the OOB area, which isn't allowed via the normal call-backs supplied. > [1] http://lists.infradead.org/pipermail/linux-mtd/2014-August/055084.html -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Wed, 8 Oct 2014 11:50:05 +0100 Subject: [PATCH 8/9] mtd: nand: stm_nand_bch: add support for ST's BCH NAND controller In-Reply-To: <20141006064030.GA20598@norris-Latitude-E6410> References: <1409143344-22458-1-git-send-email-lee.jones@linaro.org> <1409143344-22458-9-git-send-email-lee.jones@linaro.org> <20141006064030.GA20598@norris-Latitude-E6410> Message-ID: <20141008105005.GH20647@lee--X1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, 05 Oct 2014, Brian Norris wrote: > On Wed, Aug 27, 2014 at 01:42:23PM +0100, Lee Jones wrote: > > Reviewed-By: Pekon Gupta > > Signed-off-by: Lee Jones > > --- > > drivers/mtd/nand/Kconfig | 7 + > > drivers/mtd/nand/Makefile | 1 + > > drivers/mtd/nand/stm_nand_bch.c | 1616 +++++++++++++++++++++++++++++++++++++++ > > drivers/mtd/nand/stm_nand_dt.c | 110 +++ > > drivers/mtd/nand/stm_nand_dt.h | 24 + > > include/linux/mtd/stm_nand.h | 147 ++++ > > 6 files changed, 1905 insertions(+) > > create mode 100644 drivers/mtd/nand/stm_nand_bch.c > > create mode 100644 drivers/mtd/nand/stm_nand_dt.c > > create mode 100644 drivers/mtd/nand/stm_nand_dt.h > > create mode 100644 include/linux/mtd/stm_nand.h > > One more thing: you never answered my question from [1]: > > Does your driver pass the MTD tests? (drivers/mtd/tests/) It does. Apart from the ones which insist on reading the OOB area, which isn't allowed via the normal call-backs supplied. > [1] http://lists.infradead.org/pipermail/linux-mtd/2014-August/055084.html -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755939AbaJHKuN (ORCPT ); Wed, 8 Oct 2014 06:50:13 -0400 Received: from mail-vc0-f181.google.com ([209.85.220.181]:50859 "EHLO mail-vc0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754192AbaJHKuL (ORCPT ); Wed, 8 Oct 2014 06:50:11 -0400 Date: Wed, 8 Oct 2014 11:50:05 +0100 From: Lee Jones To: Brian Norris Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, pekon@pek-sem.com, linux-mtd@lists.infradead.org Subject: Re: [PATCH 8/9] mtd: nand: stm_nand_bch: add support for ST's BCH NAND controller Message-ID: <20141008105005.GH20647@lee--X1> References: <1409143344-22458-1-git-send-email-lee.jones@linaro.org> <1409143344-22458-9-git-send-email-lee.jones@linaro.org> <20141006064030.GA20598@norris-Latitude-E6410> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20141006064030.GA20598@norris-Latitude-E6410> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 05 Oct 2014, Brian Norris wrote: > On Wed, Aug 27, 2014 at 01:42:23PM +0100, Lee Jones wrote: > > Reviewed-By: Pekon Gupta > > Signed-off-by: Lee Jones > > --- > > drivers/mtd/nand/Kconfig | 7 + > > drivers/mtd/nand/Makefile | 1 + > > drivers/mtd/nand/stm_nand_bch.c | 1616 +++++++++++++++++++++++++++++++++++++++ > > drivers/mtd/nand/stm_nand_dt.c | 110 +++ > > drivers/mtd/nand/stm_nand_dt.h | 24 + > > include/linux/mtd/stm_nand.h | 147 ++++ > > 6 files changed, 1905 insertions(+) > > create mode 100644 drivers/mtd/nand/stm_nand_bch.c > > create mode 100644 drivers/mtd/nand/stm_nand_dt.c > > create mode 100644 drivers/mtd/nand/stm_nand_dt.h > > create mode 100644 include/linux/mtd/stm_nand.h > > One more thing: you never answered my question from [1]: > > Does your driver pass the MTD tests? (drivers/mtd/tests/) It does. Apart from the ones which insist on reading the OOB area, which isn't allowed via the normal call-backs supplied. > [1] http://lists.infradead.org/pipermail/linux-mtd/2014-August/055084.html -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog