Re: [PATCH 3/3] staging: dgap: introduce dgap_stop()

[Dan Carpenter <dan.carpenter@oracle.com>]

All three of these patches are good and a nice improvement.  This one is
a good bugfix.  I have some notes for later, though below.

On Wed, Oct 08, 2014 at 08:13:56PM +0900, Daeseok Youn wrote:
> diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
> index 7c79fe6..00f34b5 100644
> --- a/drivers/staging/dgap/dgap.c
> +++ b/drivers/staging/dgap/dgap.c
> @@ -71,6 +71,7 @@ MODULE_DESCRIPTION("Driver for the Digi International EPCA PCI based product lin
>  MODULE_SUPPORTED_DEVICE("dgap");
>  
>  static int dgap_start(void);
> +static void dgap_stop(void);

These kinds of forward declarations are annoying.  The whole file needs
to be re-arranged so that we don't have to deal with them.

> @@ -561,6 +563,21 @@ failed_class:
>  	return rc;
>  }
>  
> +static void dgap_stop(void)
> +{
> +	ulong lock_flags;

This is non-standard.  Traditionally it would be:

	unsigned long flags;

regards,
dan carpenter