From: David Cohen <david.a.cohen@linux.intel.com>
To: Felipe Balbi <balbi@ti.com>
Cc: gregkh@linuxfoundation.org, mina86@mina86.com,
r.baldyga@samsung.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Subject: Re: [PATCH] usb: ffs: fix regression when quirk_ep_out_aligned_size flag is set
Date: Wed, 8 Oct 2014 10:53:52 -0700 [thread overview]
Message-ID: <20141008175352.GB16791@psi-dev26.jf.intel.com> (raw)
In-Reply-To: <20141008003144.GA9957@saruman>
On Tue, Oct 07, 2014 at 07:31:44PM -0500, Felipe Balbi wrote:
> Hi,
Hi Felipe,
>
> On Tue, Oct 07, 2014 at 05:18:06PM -0700, David Cohen wrote:
> > The commit '2e4c7553cd usb: gadget: f_fs: add aio support' broke the
>
> did that commit non-aio or is only aio broken ?
That commit broke the quirk on both cases.
>
> > quirk implemented to align buffer size to maxpacketsize on out endpoint.
> > As result, functionfs does not work on Intel platforms using dwc3 driver
> > (i.e. Bay Trail and Merrifield). This patch fixes the issue.
>
> and Braswell.
>
> > This code is based on a previous Qiuxu's patch.
>
> How have you tested this ? Do you have a test-case to share ? Then I can
> add it to my tests which I have been running on my platforms too (they
> include USB20CV and USB30CV where applicable - quite a few fixes coming
> soon).
My testcase is to use Android's adbd service via function_fs (no
out-of-tree android gadget). Without the quitk, it doesn't work.
Br, David
>
> cheers
>
> --
> balbi
next prev parent reply other threads:[~2014-10-08 17:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 0:18 [PATCH] usb: ffs: fix regression when quirk_ep_out_aligned_size flag is set David Cohen
2014-10-08 0:31 ` Felipe Balbi
2014-10-08 17:53 ` David Cohen [this message]
2014-10-08 0:32 ` Felipe Balbi
2014-10-08 17:55 ` David Cohen
2014-10-08 19:54 ` Felipe Balbi
2014-10-08 11:34 ` Michal Nazarewicz
2014-10-08 21:12 ` [PATCH v2] " David Cohen
2014-10-12 19:12 ` Al Viro
2014-10-12 19:58 ` Felipe Balbi
2014-10-13 15:32 ` Felipe Balbi
2014-10-13 16:55 ` David Cohen
2014-10-13 17:03 ` Felipe Balbi
2014-10-13 18:15 ` [PATCH v3] " David Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141008175352.GB16791@psi-dev26.jf.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=qiuxu.zhuo@intel.com \
--cc=r.baldyga@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.