From: Richard Leitner <me@g0hl1n.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
richard.leitner@skidata.com
Subject: Re: [PATCH] input: avoid negative input device numbers
Date: Wed, 8 Oct 2014 23:49:27 +0200 [thread overview]
Message-ID: <20141008234927.5c4b8492@frodo> (raw)
In-Reply-To: <20141008213051.GD15198@dtor-ws>
On Wed, 8 Oct 2014 14:30:51 -0700
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> On Wed, Oct 08, 2014 at 02:25:38PM -0700, Dmitry Torokhov wrote:
> > On Wed, Oct 08, 2014 at 10:42:45PM +0200, Richard Leitner wrote:
> > > From: Richard Leitner <richard.leitner@skidata.com>
> > >
> > > Fix the format string for input device name generation to avoid
> > > negative device numbers when the id exceeds the maximum signed
> > > integer value.
> >
> > Well, it is going to take us a while to get there :)
> >
> > Applied, thank you.
>
> By the way, we have similar issue in serio and gameport code, mind
> sending fixes for them as well?
>
I'll send a patch for the serio in a few minutes.
The gameport code looks fine to me:
536 dev_set_name(&gameport->dev, "gameport%lu",
537 (unsigned long)atomic_inc_return(&gameport_no) - 1);
regards,
richard
prev parent reply other threads:[~2014-10-08 21:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 20:42 [PATCH] input: avoid negative input device numbers Richard Leitner
2014-10-08 20:49 ` [RFC] avoid (theoretical) conflicts of input device file names Richard Leitner
2014-10-08 21:30 ` Dmitry Torokhov
2014-10-08 21:25 ` [PATCH] input: avoid negative input device numbers Dmitry Torokhov
2014-10-08 21:30 ` Dmitry Torokhov
2014-10-08 21:49 ` Richard Leitner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141008234927.5c4b8492@frodo \
--to=me@g0hl1n.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.leitner@skidata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.