diff for duplicates of <20141009151605.GA8818@ulmo.nvidia.com> diff --git a/a/1.1.hdr b/a/1.1.hdr deleted file mode 100644 index 149ab5e..0000000 --- a/a/1.1.hdr +++ /dev/null @@ -1,3 +0,0 @@ -Content-Type: text/plain; charset=utf-8 -Content-Disposition: inline -Content-Transfer-Encoding: quoted-printable diff --git a/a/1.1.txt b/a/1.1.txt deleted file mode 100644 index a93529e..0000000 --- a/a/1.1.txt +++ /dev/null @@ -1,23 +0,0 @@ -On Tue, Oct 07, 2014 at 03:55:33PM +0200, Lothar Waßmann wrote: -> Change the pwm chip driver registration, so that a chip driver that -> supports polarity inversion can still be used with DTBs that don't -> provide the 'PWM_POLARITY' flag. -> -> This is done to provide polarity inversion support for the pwm-imx -> driver without having to modify all existing DTS files. - -I don't like how this throws out the window the only sanity checking we -have in place for the #pwm-cells property. - -As I understand it, the problem that you're trying to solve is one of -backwards-compatibility where existing device trees have #pwm-cells = -<2>, but the driver is extended to support flags as well. - -In that case, can we not simply make of_pwm_xlate_with_flags() support -that case transparently? That is, if the driver sets .of_pwm_n_cells to -3, we can still support #pwm-cells = <2> and use the default (no) flags -instead. - -Something like the below should do that (compile-tested only). - -Thierry diff --git a/a/1.2.hdr b/a/1.2.hdr deleted file mode 100644 index 582bfec..0000000 --- a/a/1.2.hdr +++ /dev/null @@ -1,3 +0,0 @@ -Content-Type: text/plain; charset=us-ascii -Content-Disposition: inline; filename=patch -Content-Transfer-Encoding: quoted-printable diff --git a/a/1.2.txt b/N1/1.txt similarity index 58% rename from a/1.2.txt rename to N1/1.txt index 8a334fc..0d63ad2 100644 --- a/a/1.2.txt +++ b/N1/1.txt @@ -1,3 +1,27 @@ +On Tue, Oct 07, 2014 at 03:55:33PM +0200, Lothar Wa?mann wrote: +> Change the pwm chip driver registration, so that a chip driver that +> supports polarity inversion can still be used with DTBs that don't +> provide the 'PWM_POLARITY' flag. +> +> This is done to provide polarity inversion support for the pwm-imx +> driver without having to modify all existing DTS files. + +I don't like how this throws out the window the only sanity checking we +have in place for the #pwm-cells property. + +As I understand it, the problem that you're trying to solve is one of +backwards-compatibility where existing device trees have #pwm-cells = +<2>, but the driver is extended to support flags as well. + +In that case, can we not simply make of_pwm_xlate_with_flags() support +that case transparently? That is, if the driver sets .of_pwm_n_cells to +3, we can still support #pwm-cells = <2> and use the default (no) flags +instead. + +Something like the below should do that (compile-tested only). + +Thierry +-------------- next part -------------- diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 966497d10c6e..89a5e309b0a3 100644 --- a/drivers/pwm/core.c @@ -63,3 +87,10 @@ index 966497d10c6e..89a5e309b0a3 100644 pwm = pc->of_xlate(pc, &args); if (IS_ERR(pwm)) goto put; +-------------- next part -------------- +A non-text attachment was scrubbed... +Name: not available +Type: application/pgp-signature +Size: 819 bytes +Desc: not available +URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141009/da3e1b34/attachment.sig> diff --git a/a/2.bin b/a/2.bin deleted file mode 100644 index 948b54a..0000000 --- a/a/2.bin +++ /dev/null @@ -1,17 +0,0 @@ ------BEGIN PGP SIGNATURE----- -Version: GnuPG v2 - -iQIcBAEBAgAGBQJUNqa1AAoJEN0jrNd/PrOhZnYQAKXzrn1T0DKgUj+x6p3uMkNJ -eJ0icrrtK8mfxx0Gq7J2zv1sAHQTqBr0l/1nhziZwntRmTVMKMHeIN2Fzx1Y3BUl -SknVEU7+0GX+yFkdx0CymP7elrlAjafOJzQLSxPwd55jMXn++/KubHiCzKBc3KWi -vzuXpABX5NfwgHFJEhWSX9Ev38tk/CxqO8IZ6DohiWV89X9c/dm3adv0ZK+EcNSX -g7VIsiAupDBbUXZVNUxOzR4g0aOQsBTo4ueXnsjc56/XEUTQsGXkPfJaPoU+RCQs -bjpsCciCT4Q9kGMvikEsAFRXEvyT29flFIMcOKUBF5n88XeQVrH7VBPbqqeI90Ah -ZfI/oFXMu1bvzrn+Gq5y6cDRHToqKELV/+GKu9Jq9FjeofaIRTwUt0MifUsLOUMM -auU/IEA+nEysuC4CsdDjnjZthNKPF6D+F7kp4c9sj+TK2HyUbgKiF2CMliedmc/I -FO6Nda24jvjsQyN33qBjzLHU2+v+cszJNYooY/wNHz1uqvUt84x+Z4R52/O4DnEa -yv3Tqal21b/F0gD8NybcW7JckFU8asrc6CYfTr6hsPWW+t76D2uBM0mDRXG1FF5u -If+M0IkSyc2c3mM4hXQSltDyl1uqeAhc8kBd8B0tGF4lKD/sFP2ZygZkd7T1S8zT -D1mrNCTGdTtLhY1InWrd -=MR6P ------END PGP SIGNATURE----- diff --git a/a/2.hdr b/a/2.hdr deleted file mode 100644 index a09cc95..0000000 --- a/a/2.hdr +++ /dev/null @@ -1 +0,0 @@ -Content-Type: application/pgp-signature diff --git a/a/content_digest b/N1/content_digest index 38e241f..13171bb 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,17 +1,12 @@ "ref\01412690134-13712-1-git-send-email-LW@KARO-electronics.de\0" "ref\01412690134-13712-3-git-send-email-LW@KARO-electronics.de\0" - "From\0Thierry Reding <thierry.reding@gmail.com>\0" - "Subject\0Re: [PATCHv5 2/3] pwm: make the PWM_POLARITY flag in DTB optional\0" + "From\0thierry.reding@gmail.com (Thierry Reding)\0" + "Subject\0[PATCHv5 2/3] pwm: make the PWM_POLARITY flag in DTB optional\0" "Date\0Thu, 9 Oct 2014 17:16:08 +0200\0" - "To\0Lothar Wa\303\237mann <LW@karo-electronics.de>\0" - "Cc\0linux-pwm@vger.kernel.org" - linux-arm-kernel@lists.infradead.org - Shawn Guo <shawn.guo@linaro.org> - Sascha Hauer <s.hauer@pengutronix.de> - " Tony Prisk <linux@prisktech.co.nz>\0" - "\02:1.1\0" + "To\0linux-arm-kernel@lists.infradead.org\0" + "\00:1\0" "b\0" - "On Tue, Oct 07, 2014 at 03:55:33PM +0200, Lothar Wa\303\237mann wrote:\n" + "On Tue, Oct 07, 2014 at 03:55:33PM +0200, Lothar Wa?mann wrote:\n" "> Change the pwm chip driver registration, so that a chip driver that\n" "> supports polarity inversion can still be used with DTBs that don't\n" "> provide the 'PWM_POLARITY' flag.\n" @@ -33,10 +28,8 @@ "\n" "Something like the below should do that (compile-tested only).\n" "\n" - Thierry - "\02:1.2\0" - "fn\0patch\0" - "b\0" + "Thierry\n" + "-------------- next part --------------\n" "diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c\n" "index 966497d10c6e..89a5e309b0a3 100644\n" "--- a/drivers/pwm/core.c\n" @@ -101,25 +94,13 @@ "-\n" " \tpwm = pc->of_xlate(pc, &args);\n" " \tif (IS_ERR(pwm))\n" - " \t\tgoto put;" - "\01:2\0" - "b\0" - "-----BEGIN PGP SIGNATURE-----\n" - "Version: GnuPG v2\n" - "\n" - "iQIcBAEBAgAGBQJUNqa1AAoJEN0jrNd/PrOhZnYQAKXzrn1T0DKgUj+x6p3uMkNJ\n" - "eJ0icrrtK8mfxx0Gq7J2zv1sAHQTqBr0l/1nhziZwntRmTVMKMHeIN2Fzx1Y3BUl\n" - "SknVEU7+0GX+yFkdx0CymP7elrlAjafOJzQLSxPwd55jMXn++/KubHiCzKBc3KWi\n" - "vzuXpABX5NfwgHFJEhWSX9Ev38tk/CxqO8IZ6DohiWV89X9c/dm3adv0ZK+EcNSX\n" - "g7VIsiAupDBbUXZVNUxOzR4g0aOQsBTo4ueXnsjc56/XEUTQsGXkPfJaPoU+RCQs\n" - "bjpsCciCT4Q9kGMvikEsAFRXEvyT29flFIMcOKUBF5n88XeQVrH7VBPbqqeI90Ah\n" - "ZfI/oFXMu1bvzrn+Gq5y6cDRHToqKELV/+GKu9Jq9FjeofaIRTwUt0MifUsLOUMM\n" - "auU/IEA+nEysuC4CsdDjnjZthNKPF6D+F7kp4c9sj+TK2HyUbgKiF2CMliedmc/I\n" - "FO6Nda24jvjsQyN33qBjzLHU2+v+cszJNYooY/wNHz1uqvUt84x+Z4R52/O4DnEa\n" - "yv3Tqal21b/F0gD8NybcW7JckFU8asrc6CYfTr6hsPWW+t76D2uBM0mDRXG1FF5u\n" - "If+M0IkSyc2c3mM4hXQSltDyl1uqeAhc8kBd8B0tGF4lKD/sFP2ZygZkd7T1S8zT\n" - "D1mrNCTGdTtLhY1InWrd\n" - "=MR6P\n" - "-----END PGP SIGNATURE-----\n" + " \t\tgoto put;\n" + "-------------- next part --------------\n" + "A non-text attachment was scrubbed...\n" + "Name: not available\n" + "Type: application/pgp-signature\n" + "Size: 819 bytes\n" + "Desc: not available\n" + URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141009/da3e1b34/attachment.sig> -e9317492c3c88b362a34b38603234c23d83964c18bbe444ca3aa0efdf5b078f7 +a75705666b054941cb0b7cc18f83d606f0820ccba87195c86ba531f2058535bf
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.