From: "Benoît Canet" <benoit.canet@nodalink.com>
To: Max Reitz <mreitz@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Benoît Canet" <benoit.canet@nodalink.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/2] raw-posix: Fix raw_co_get_block_status()
Date: Thu, 9 Oct 2014 18:58:45 +0000 [thread overview]
Message-ID: <20141009185845.GA5717@nodalink.com> (raw)
In-Reply-To: <543593D7.4070909@redhat.com>
On Wed, Oct 08, 2014 at 09:43:19PM +0200, Max Reitz wrote:
> On 22.09.2014 17:36, Max Reitz wrote:
> >raw_co_get_block_status() should return 0 and set *pnum to 0 after the
> >EOF; currently it does this merely by accident, so implement it
> >directly. Also, nb_sectors should be clamped against the image end.
> >
> >While doing that, centralize the generation of
> >raw_co_get_block_status()'s return value along the way.
> >
> >
> >v2:
> >- Patch 1: Clamp nb_sectors against image end
> >- Patch 2: Fix alignment issue
> >
> >
> >Max Reitz (2):
> > raw-posix: Fix raw_co_get_block_status() after EOF
> > raw-posix: raw_co_get_block_status() return value
> >
> > block/raw-posix.c | 36 ++++++++++++++++++++++--------------
> > 1 file changed, 22 insertions(+), 14 deletions(-)
>
> Ping. (This should be rather simple to review)
Hi Max,
I will review these tomorow.
Best regards
Benoît
next prev parent reply other threads:[~2014-10-09 18:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 15:36 [Qemu-devel] [PATCH v2 0/2] raw-posix: Fix raw_co_get_block_status() Max Reitz
2014-09-22 15:36 ` [Qemu-devel] [PATCH v2 1/2] raw-posix: Fix raw_co_get_block_status() after EOF Max Reitz
2014-10-09 4:13 ` Eric Blake
2014-10-16 8:30 ` Kevin Wolf
2014-09-22 15:36 ` [Qemu-devel] [PATCH v2 2/2] raw-posix: raw_co_get_block_status() return value Max Reitz
2014-10-09 4:16 ` Eric Blake
2014-10-08 19:43 ` [Qemu-devel] [PATCH v2 0/2] raw-posix: Fix raw_co_get_block_status() Max Reitz
2014-10-09 18:58 ` Benoît Canet [this message]
2014-10-11 8:55 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141009185845.GA5717@nodalink.com \
--to=benoit.canet@nodalink.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.