From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH 08/44] kernel: Move pm_power_off to common code Date: Thu, 9 Oct 2014 22:24:19 +0200 Message-ID: <20141009202419.GA16885@amd> References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-9-git-send-email-linux@roeck-us.net> <20141009103847.GC6787@amd> <54368A30.9070101@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <54368A30.9070101@roeck-us.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Guenter Roeck Cc: linux-m32r-ja@ml.linux-m32r.org, linux-mips@linux-mips.org, linux-efi@vger.kernel.org, linux-ia64@vger.kernel.org, Steven Miao , linux-xtensa@linux-xtensa.org, Boris Ostrovsky , Catalin Marinas , Will Deacon , David Howells , Max Filippov , Paul Mackerras , Ralf Baechle , "H. Peter Anvin" , Guan Xuetao , Thomas Gleixner , Lennox Wu , Hans-Christian Egtvedt , devel@driverdev.osuosl.org, linux-s390@vger.kernel.org, Jesper Nilsson , lguest@lists.ozlabs.org, Russell King , linux-c6x-dev@linux-c6x.org, Len Brown , "David S. Miller" Hi! > >>@@ -184,6 +179,8 @@ machine_halt(void) > >> void > >> machine_power_off(void) > >> { > >>+ do_kernel_poweroff(); > >>+ > > > >poweroff -> power_off for consistency. > > > Dunno; matter of personal preference. I started with that, but ultimately went > with poweroff to distinguish poweroff handler functions from existing code, > specifically kernel_power_off(). That works for you, but once it is merged, it is ugly/confusing typo. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 09 Oct 2014 22:24:21 +0200 (CEST) Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:49234 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27010999AbaJIUYUVQILC (ORCPT ); Thu, 9 Oct 2014 22:24:20 +0200 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id BCAD981E3A; Thu, 9 Oct 2014 22:24:19 +0200 (CEST) Date: Thu, 9 Oct 2014 22:24:19 +0200 From: Pavel Machek To: Guenter Roeck Cc: linux-kernel@vger.kernel.org, adi-buildroot-devel@lists.sourceforge.net, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, lguest@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-alpha@vger.kernel.org, linux-am33-list@redhat.com, linux-cris-kernel@axis.com, linux-efi@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-m32r-ja@ml.linux-m32r.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-xtensa@linux-xtensa.org, openipmi-developer@lists.sourceforge.net, user-mode-linux-devel@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-metag@vger.kernel.org, linux-mips@linux-mips.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Haavard Skinnemoen , Hans-Christian Egtvedt , Steven Miao , Mark Salter , Aurelien Jacquiot , Mikael Starvik , Jesper Nilsson , David Howells , Richard Kuo , Tony Luck , Fenghua Yu , Hirokazu Takata , Geert Uytterhoeven , James Hogan , Michal Simek , Ralf Baechle , Koichi Yasutake , Jonas Bonn , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Martin Schwidefsky , Heiko Carstens , Chen Liqin , Lennox Wu , "David S. Miller" , Chris Metcalf , Jeff Dike , Richard Weinberger , Guan Xuetao , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Konrad Rzeszutek Wilk , Boris Ostrovsky , David Vrabel , Chris Zankel , Max Filippov , "Rafael J. Wysocki" , Len Brown Subject: Re: [PATCH 08/44] kernel: Move pm_power_off to common code Message-ID: <20141009202419.GA16885@amd> References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-9-git-send-email-linux@roeck-us.net> <20141009103847.GC6787@amd> <54368A30.9070101@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54368A30.9070101@roeck-us.net> User-Agent: Mutt/1.5.23 (2014-03-12) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 43163 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: pavel@denx.de Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Hi! > >>@@ -184,6 +179,8 @@ machine_halt(void) > >> void > >> machine_power_off(void) > >> { > >>+ do_kernel_poweroff(); > >>+ > > > >poweroff -> power_off for consistency. > > > Dunno; matter of personal preference. I started with that, but ultimately went > with poweroff to distinguish poweroff handler functions from existing code, > specifically kernel_power_off(). That works for you, but once it is merged, it is ugly/confusing typo. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH 08/44] kernel: Move pm_power_off to common code Date: Thu, 9 Oct 2014 22:24:19 +0200 Message-ID: <20141009202419.GA16885@amd> References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-9-git-send-email-linux@roeck-us.net> <20141009103847.GC6787@amd> <54368A30.9070101@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: linux-m32r-ja@ml.linux-m32r.org, linux-mips@linux-mips.org, linux-efi@vger.kernel.org, linux-ia64@vger.kernel.org, Steven Miao , linux-xtensa@linux-xtensa.org, Boris Ostrovsky , Catalin Marinas , Will Deacon , David Howells , Max Filippov , Paul Mackerras , Ralf Baechle , "H. Peter Anvin" , Guan Xuetao , Thomas Gleixner , Lennox Wu , Hans-Christian Egtvedt , devel@driverdev.osuosl.org, linux-s390@vger.kernel.org, Jesper Nilsson , lguest@lists.ozlabs.org, Russell King , linux-c6x-dev@linux-c6x.org, Len Brown , "David S. Miller" Return-path: In-Reply-To: <54368A30.9070101@roeck-us.net> List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Hi! > >>@@ -184,6 +179,8 @@ machine_halt(void) > >> void > >> machine_power_off(void) > >> { > >>+ do_kernel_poweroff(); > >>+ > > > >poweroff -> power_off for consistency. > > > Dunno; matter of personal preference. I started with that, but ultimately went > with poweroff to distinguish poweroff handler functions from existing code, > specifically kernel_power_off(). That works for you, but once it is merged, it is ugly/confusing typo. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 9 Oct 2014 22:24:19 +0200 From: Pavel Machek To: Guenter Roeck Subject: Re: [PATCH 08/44] kernel: Move pm_power_off to common code Message-ID: <20141009202419.GA16885@amd> References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-9-git-send-email-linux@roeck-us.net> <20141009103847.GC6787@amd> <54368A30.9070101@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <54368A30.9070101@roeck-us.net> Cc: linux-m32r-ja@ml.linux-m32r.org, linux-mips@linux-mips.org, linux-efi@vger.kernel.org, linux-ia64@vger.kernel.org, Steven Miao , linux-xtensa@linux-xtensa.org, Boris Ostrovsky , Catalin Marinas , Will Deacon , David Howells , Max Filippov , Paul Mackerras , Ralf Baechle , "H. Peter Anvin" , Guan Xuetao , Thomas Gleixner , Lennox Wu , Hans-Christian Egtvedt , devel@driverdev.osuosl.org, linux-s390@vger.kernel.org, Jesper Nilsson , lguest@lists.ozlabs.org, Russell King , linux-c6x-dev@linux-c6x.org, Len Brown , "David S. Miller" , linux-hexagon@vger.kernel.org, Hirokazu Takata , linux-sh@vger.kernel.org, "James E.J. Bottomley" , linux-acpi@vger.kernel.org, Ingo Molnar , Geert Uytterhoeven , Mark Salter , xen-devel@lists.xenproject.org, Matt Turner , Chen Liqin , Jonas Bonn , Haavard Skinnemoen , devicetree@vger.kernel.org, James Hogan , user-mode-linux-devel@lists.sourceforge.net, linux-pm@vger.kernel.org, Aurelien Jacquiot , Heiko Carstens , Jeff Dike , adi-buildroot-devel@lists.sourceforge.net, Chris Metcalf , Konrad Rzeszutek Wilk , Mikael Starvik , Richard Weinberger , linux-m68k@lists.linux-m68k.org, linux-am33-list@redhat.com, Ivan Kokshaysky , linux-tegra@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-metag@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Richard Henderson , Chris Zankel , Michal Simek , Tony Luck , linux-parisc@vger.kernel.org, linux-cris-kernel@axis.com, Vineet Gupta , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Fenghua Yu , Richard Kuo , David Vrabel , linux-alpha@vger.kernel.org, Martin Schwidefsky , Koichi Yasutake , linuxppc-dev@lists.ozlabs.org, Helge Deller List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi! > >>@@ -184,6 +179,8 @@ machine_halt(void) > >> void > >> machine_power_off(void) > >> { > >>+ do_kernel_poweroff(); > >>+ > > > >poweroff -> power_off for consistency. > > > Dunno; matter of personal preference. I started with that, but ultimately went > with poweroff to distinguish poweroff handler functions from existing code, > specifically kernel_power_off(). That works for you, but once it is merged, it is ugly/confusing typo. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html