All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Buddenhagen <olafbuddenhagen@gmx.net>
To: dri-devel@lists.freedesktop.org
Subject: Re: AMD GPU new API for new module
Date: Fri, 10 Oct 2014 04:25:13 +0200	[thread overview]
Message-ID: <20141010022509.GA13466@alien.local> (raw)
In-Reply-To: <20141008160026.GA7643@gmail.com>

Hi,

On Wed, Oct 08, 2014 at 12:00:27PM -0400, Jerome Glisse wrote:

[...]
> And now all ioctl go through this single entry point :
>
> int radeon_ioctl_stub(int ioctl, void *data, ...)
> {
> 	struct radeon_ioctl *rio = data;
>
> 	return rdispatch_ioctls[rio->version][ioctl](data, ...);
> }

I advise against this: it's essentially implementing IOCTLs on top of an
IOCTL...

It doesn't really reduce the maintenance burden: just moves it from the
standard IOCTL dispatching to a custom mechanism; while adding extra
complexity, and making the interface more opaque. (Think strace, or
Valgrind.)

-antrik-

      parent reply	other threads:[~2014-10-15 14:48 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-08 16:00 AMD GPU new API for new module Jerome Glisse
2014-10-08 16:43 ` Christian König
2014-10-09  6:54 ` Oded Gabbay
2014-10-09  8:02   ` Jerome Glisse
2014-10-09 10:15     ` Oded Gabbay
2014-10-09 15:55       ` Daniel Vetter
2014-10-09 18:33         ` Oded Gabbay
2014-10-11 18:30           ` Daniel Vetter
2014-10-12  8:13             ` Oded Gabbay
2014-10-12  9:33             ` Christian König
2014-10-09  7:32 ` Rob Clark
2014-10-09  7:54   ` Jerome Glisse
2014-10-09  9:49     ` Christian König
2014-10-09 12:13     ` Rob Clark
2014-10-09  9:20 ` Daniel Vetter
2014-10-13 21:13   ` Dave Airlie
2014-10-10  2:25 ` Olaf Buddenhagen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141010022509.GA13466@alien.local \
    --to=olafbuddenhagen@gmx.net \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.