From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH for-xen-4.5] Add configure --with-extra-cflags-* Date: Fri, 10 Oct 2014 08:55:57 +0200 Message-ID: <20141010065557.GA24574@aepfle.de> References: <1412847832-24047-1-git-send-email-olaf@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1412847832-24047-1-git-send-email-olaf@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: Wei Liu , Stefano Stabellini , Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org On Thu, Oct 09, Olaf Hering wrote: > +AC_ARG_WITH([extra-cflags-tools], > + AS_HELP_STRING([--with-extra-cflags-tools="EXTRA_CFLAGS"], > + [Additional CFLAGS to be used to build tools.]), > + [EXTRA_CFLAGS_XEN_TOOLS=$withval], > + [EXTRA_CFLAGS_XEN_TOOLS=]) > +AC_SUBST(EXTRA_CFLAGS_XEN_TOOLS) I wonder why all the other --with-foo are not done that way as well. It looks like they would take the variable from the environment and do AC_SUBST(). IMO private variables like seabios_path, ovmf_path, EXTRA_QEMUU_CONFIGURE_ARGS should not be passed via environment. I also question if --with-foo=no is useful at all. My suggestion is to convert these three to the style quoted above: a --with-foo=val assigns $val to the given private variable, otherwise the private variable is initialized empty. What do you think? Olaf