From: Johan Hovold <johan@kernel.org>
To: Frans Klaver <frans.klaver@xsens.com>
Cc: Johan Hovold <johan@kernel.org>,
stable@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: serial: ftdi_sio: add Awinda Station and Dongle products
Date: Fri, 10 Oct 2014 11:34:43 +0200 [thread overview]
Message-ID: <20141010093443.GD12494@localhost> (raw)
In-Reply-To: <1412933547-10906-1-git-send-email-frans.klaver@xsens.com>
On Fri, Oct 10, 2014 at 11:32:27AM +0200, Frans Klaver wrote:
> Add new IDs for the Xsens Awinda Station and Awinda Dongle.
>
> While at it, order the definitions by PID and add a logical separation
> between devices using Xsens' VID and those using FTDI's VID.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Frans Klaver <frans.klaver@xsens.com>
> ---
> drivers/usb/serial/ftdi_sio.c | 2 ++
> drivers/usb/serial/ftdi_sio_ids.h | 6 +++++-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
> index dc72b92..e4eccb6 100644
> --- a/drivers/usb/serial/ftdi_sio.c
> +++ b/drivers/usb/serial/ftdi_sio.c
> @@ -661,6 +661,8 @@ static const struct usb_device_id id_table_combined[] = {
> { USB_DEVICE(FTDI_VID, XSENS_CONVERTER_5_PID) },
> { USB_DEVICE(FTDI_VID, XSENS_CONVERTER_6_PID) },
> { USB_DEVICE(FTDI_VID, XSENS_CONVERTER_7_PID) },
> + { USB_DEVICE(XSENS_VID, XSENS_AWINDA_STATION_PID) },
> + { USB_DEVICE(XSENS_VID, XSENS_AWINDA_DONGLE_PID) },
These are still not in alphabetical order. :)
> { USB_DEVICE(XSENS_VID, XSENS_CONVERTER_PID) },
> { USB_DEVICE(XSENS_VID, XSENS_MTW_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_OMNI1509) },
> diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h
> index 5937b2d..b68084c 100644
> --- a/drivers/usb/serial/ftdi_sio_ids.h
> +++ b/drivers/usb/serial/ftdi_sio_ids.h
> @@ -143,8 +143,12 @@
> * Xsens Technologies BV products (http://www.xsens.com).
> */
> #define XSENS_VID 0x2639
> -#define XSENS_CONVERTER_PID 0xD00D /* Xsens USB-serial converter */
> +#define XSENS_AWINDA_STATION_PID 0x0101
> +#define XSENS_AWINDA_DONGLE_PID 0x0102
> #define XSENS_MTW_PID 0x0200 /* Xsens MTw */
> +#define XSENS_CONVERTER_PID 0xD00D /* Xsens USB-serial converter */
> +
> +/* Xsens devices using FTDI VID */
> #define XSENS_CONVERTER_0_PID 0xD388 /* Xsens USB converter */
> #define XSENS_CONVERTER_1_PID 0xD389 /* Xsens Wireless Receiver */
> #define XSENS_CONVERTER_2_PID 0xD38A
Looks good otherwise.
Thanks,
Johan
next prev parent reply other threads:[~2014-10-10 9:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 8:44 [PATCH] usb: serial: ftdi_sio: add Awinda Station and Dongle products Frans Klaver
2014-10-10 9:01 ` Johan Hovold
2014-10-10 9:12 ` Frans Klaver
2014-10-10 9:20 ` Johan Hovold
2014-10-10 9:25 ` Frans Klaver
2014-10-10 9:32 ` [PATCH v2] " Frans Klaver
2014-10-10 9:34 ` Johan Hovold [this message]
2014-10-10 9:45 ` Frans Klaver
2014-10-10 9:52 ` [PATCH] " Frans Klaver
2014-10-10 9:54 ` Johan Hovold
2014-10-10 10:32 ` Frans Klaver
2014-10-22 8:14 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141010093443.GD12494@localhost \
--to=johan@kernel.org \
--cc=frans.klaver@xsens.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.