All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH] ath10k: fix kernel panic while shutting down AP
Date: Fri, 10 Oct 2014 15:06:31 +0530	[thread overview]
Message-ID: <20141010093629.GA31275@qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQ=BuSrkBxkbsShZM=Zh8uqye5u0HydpfM9roubgi0-4tQ@mail.gmail.com>

On Wed, Oct 08, 2014 at 02:16:18PM +0200, Michal Kazior wrote:
> On 8 October 2014 13:08, Rajkumar Manoharan <rmanohar@qti.qualcomm.com> wrote:
> > On Wed, Oct 08, 2014 at 12:50:28PM +0200, Michal Kazior wrote:
> >> On 8 October 2014 12:33, Rajkumar Manoharan <rmanohar@qti.qualcomm.com> wrote:
> >> > On Wed, Oct 08, 2014 at 11:45:38AM +0200, Michal Kazior wrote:
> >> >> On 8 October 2014 11:16, Rajkumar Manoharan <rmanohar@qti.qualcomm.com> wrote:
> >> >> > The commit "ath10k: workaround fw beaconing bug" is freeing
> >> >> > DMA-coherent memory in irq context which is hitting BUG ON
> >> >> > in ARM platforms. Fix this by moving dma_free out of spin
> >> >> > lock.
> >> >>
> >> >> I hardly see how moving the freeing outside the spinlock is a fix.
> >> >>
[...]
> 
> My thinking was GFP_ given to dma_alloc_coherent could impact
> behaviour of dma_free_coherent (e.g. different kind of pages is
> allocated so different kind of freeing will be involved) but I may be
> wrong.
> 
> Can you give it a try, please?
>
Michal,

Sorry for the delay.. Good catch. It is working after changing the GFP flag to
atomic. Will send the updated version and remove the backtrace from
commit log as well.

Thanks for the review.

-Rajkumar

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: fix kernel panic while shutting down AP
Date: Fri, 10 Oct 2014 15:06:31 +0530	[thread overview]
Message-ID: <20141010093629.GA31275@qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQ=BuSrkBxkbsShZM=Zh8uqye5u0HydpfM9roubgi0-4tQ@mail.gmail.com>

On Wed, Oct 08, 2014 at 02:16:18PM +0200, Michal Kazior wrote:
> On 8 October 2014 13:08, Rajkumar Manoharan <rmanohar@qti.qualcomm.com> wrote:
> > On Wed, Oct 08, 2014 at 12:50:28PM +0200, Michal Kazior wrote:
> >> On 8 October 2014 12:33, Rajkumar Manoharan <rmanohar@qti.qualcomm.com> wrote:
> >> > On Wed, Oct 08, 2014 at 11:45:38AM +0200, Michal Kazior wrote:
> >> >> On 8 October 2014 11:16, Rajkumar Manoharan <rmanohar@qti.qualcomm.com> wrote:
> >> >> > The commit "ath10k: workaround fw beaconing bug" is freeing
> >> >> > DMA-coherent memory in irq context which is hitting BUG ON
> >> >> > in ARM platforms. Fix this by moving dma_free out of spin
> >> >> > lock.
> >> >>
> >> >> I hardly see how moving the freeing outside the spinlock is a fix.
> >> >>
[...]
> 
> My thinking was GFP_ given to dma_alloc_coherent could impact
> behaviour of dma_free_coherent (e.g. different kind of pages is
> allocated so different kind of freeing will be involved) but I may be
> wrong.
> 
> Can you give it a try, please?
>
Michal,

Sorry for the delay.. Good catch. It is working after changing the GFP flag to
atomic. Will send the updated version and remove the backtrace from
commit log as well.

Thanks for the review.

-Rajkumar

  reply	other threads:[~2014-10-10  9:35 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-08  9:16 [PATCH] ath10k: fix kernel panic while shutting down AP Rajkumar Manoharan
2014-10-08  9:16 ` Rajkumar Manoharan
2014-10-08  9:45 ` Michal Kazior
2014-10-08  9:45   ` Michal Kazior
2014-10-08 10:33   ` Rajkumar Manoharan
2014-10-08 10:33     ` Rajkumar Manoharan
2014-10-08 10:50     ` Michal Kazior
2014-10-08 10:50       ` Michal Kazior
2014-10-08 11:08       ` Rajkumar Manoharan
2014-10-08 11:08         ` Rajkumar Manoharan
2014-10-08 11:13         ` Rajkumar Manoharan
2014-10-08 11:13           ` Rajkumar Manoharan
2014-10-08 12:17           ` Michal Kazior
2014-10-08 12:17             ` Michal Kazior
2014-10-08 12:16         ` Michal Kazior
2014-10-08 12:16           ` Michal Kazior
2014-10-10  9:36           ` Rajkumar Manoharan [this message]
2014-10-10  9:36             ` Rajkumar Manoharan
2014-10-08  9:52 ` Kalle Valo
2014-10-08  9:52   ` Kalle Valo
2014-10-08 10:48   ` Rajkumar Manoharan
2014-10-08 10:48     ` Rajkumar Manoharan
2014-10-08 12:24     ` Michal Kazior
2014-10-08 12:24       ` Michal Kazior
2014-10-08 12:37       ` Kalle Valo
2014-10-08 12:37         ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141010093629.GA31275@qca.qualcomm.com \
    --to=rmanohar@qti.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.