From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] tools/hotplug/Linux: Fix build
Date: Fri, 10 Oct 2014 12:03:44 +0200
Message-ID: <20141010100343.GB26050@aepfle.de>
References: <1412872535-8221-1-git-send-email-anthony.perard@citrix.com>
	<20141009165408.GB12637@aepfle.de> <5436BEC1.9020604@citrix.com>
	<1412930128.10650.17.camel@citrix.com>
	<1412930678.10650.20.camel@citrix.com>
	<20141010091933.GA6178@zion.uk.xensource.com>
	<1412932846.27111.2.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1412932846.27111.2.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Xen Devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Fri, Oct 10, Ian Campbell wrote:

> On Fri, 2014-10-10 at 10:19 +0100, Wei Liu wrote:
> > On Fri, Oct 10, 2014 at 09:44:38AM +0100, Ian Campbell wrote:
> > [...]
> > > Should subdirs-install depend on subdirs-all perhaps?
> > > 
> > > commit 66bb8b04f0032ddf0aa007b0850be1ec15477d60
> > > Author: Ian Campbell <ian.campbell@citrix.com>
> > > Date:   Fri Oct 10 09:35:34 2014 +0100
> > > 
> > >     Revert "tools/hotplug: fix race during xen.conf creation"
> > >     
> > >     This reverts commit eac3f5122fd4769b2885d8ad78bcbcf5df2472c1.
> > >     
> > >     The "all" target should never depend on "install", it is supposed to only build
> > >     not install.
> > >     
> > >     Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > > 
> > > diff --git a/tools/hotplug/Linux/systemd/Makefile b/tools/hotplug/Linux/systemd/Makefile
> > > index 6950d24..9c58b33 100644
> > > --- a/tools/hotplug/Linux/systemd/Makefile
> > > +++ b/tools/hotplug/Linux/systemd/Makefile
> > > @@ -21,11 +21,10 @@ ALL_XEN_SYSTEMD =	$(XEN_SYSTEMD_MODULES)  \
> > >  			$(XEN_SYSTEMD_SERVICE)
> > >  
> > >  .PHONY: all
> > > -all:	install
> > > +all:	$(ALL_XEN_SYSTEMD)
> > >  
> > >  .PHONY: clean
> > >  clean:
> > > -	rm -f $(ALL_XEN_SYSTEMD)
> > >  
> > 
> > Now clean target just becomes empty...
> 
> ... the perils of lumping multiple changes into a single patch...

And it was wrong anyway because it will wipe everything in that dir. If
at all, it should have been "rm -f $(XEN_SYSTEMD_MODULES)" to wipe the
generated files.


Olaf