From: Peter Zijlstra <peterz@infradead.org>
To: Wanpeng Li <wanpeng.li@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@arm.com>,
Kirill V Tkhai <tkhai@yandex.ru>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/deadline: do not try to push tasks if pinned task switches to dl
Date: Fri, 10 Oct 2014 12:10:16 +0200 [thread overview]
Message-ID: <20141010101016.GJ10832@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <1412908997-15396-1-git-send-email-wanpeng.li@linux.intel.com>
On Fri, Oct 10, 2014 at 10:43:17AM +0800, Wanpeng Li wrote:
> As Kirill mentioned(https://lkml.org/lkml/2013/1/29/118):
> | If rq has already had 2 or more pushable tasks and we try to add a
> | pinned task then call of push_rt_task will just waste a time.
>
> Just switched pinned task is not able to be pushed. If the rq had had
> several dl tasks before they have already been considered as candidates
> to be pushed (or pulled). This patch does the same behavior as rt class
> which introduced by commit 104479 (sched/rt: Do not try to push tasks
> if pinned task switches to RT).
Checkpatch rightly complains:
ERROR: Please use 12 or more chars for the git commit ID like: 'commit 10447917551e ("sched/rt: Do not try to push tasks if pinned task switches to RT")'
#12:
which introduced by commit 104479 (sched/rt: Do not try to push tasks
next prev parent reply other threads:[~2014-10-10 10:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 2:43 [PATCH] sched/deadline: do not try to push tasks if pinned task switches to dl Wanpeng Li
2014-10-10 10:10 ` Peter Zijlstra [this message]
2014-10-10 10:26 ` Wanpeng Li
2014-10-10 10:56 ` Peter Zijlstra
2014-10-10 11:00 ` Wanpeng Li
2014-10-20 15:42 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141010101016.GJ10832@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tkhai@yandex.ru \
--cc=wanpeng.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.