From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Subject: Re: [PATCH 2/2] regulator: twl: use platform data in the DT based boot also Date: Fri, 10 Oct 2014 08:43:09 -0500 Message-ID: <20141010134308.GA15977@kahuna> References: <1412948442-19896-1-git-send-email-t-kristo@ti.com> <1412948442-19896-3-git-send-email-t-kristo@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:44976 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752664AbaJJNne (ORCPT ); Fri, 10 Oct 2014 09:43:34 -0400 Content-Disposition: inline In-Reply-To: <1412948442-19896-3-git-send-email-t-kristo@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tero Kristo Cc: linux-omap@vger.kernel.org, tony@atomide.com, linux-arm-kernel@lists.infradead.org On 16:40-20141010, Tero Kristo wrote: > This allows to pass platform information during a DT boot also, currently > this is completely ignored. Needed for supporting the platform specific > regulator set_voltage / get_voltage ops for the SMPS regulators. > > Signed-off-by: Tero Kristo > To: Liam Girdwood > To: Mark Brown > --- > drivers/regulator/twl-regulator.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c > index 0b4f866..2c4fa06 100644 > --- a/drivers/regulator/twl-regulator.c > +++ b/drivers/regulator/twl-regulator.c > @@ -1103,9 +1103,9 @@ static int twlreg_probe(struct platform_device *pdev) > if (match) { > template = match->data; > id = template->desc.id; > + drvdata = dev_get_platdata(&pdev->dev); > initdata = of_get_regulator_init_data(&pdev->dev, > pdev->dev.of_node); > - drvdata = NULL; > } else { > id = pdev->id; > initdata = dev_get_platdata(&pdev->dev); > -- > 1.7.9.5 > please post this separately and liam, mark need to be in cc. Unfortunately, I think we might be pushed back with pdata should'nt be in of boot. So a slightly longer commit message might be necessary. -- Regards, Nishanth Menon From mboxrd@z Thu Jan 1 00:00:00 1970 From: nm@ti.com (Nishanth Menon) Date: Fri, 10 Oct 2014 08:43:09 -0500 Subject: [PATCH 2/2] regulator: twl: use platform data in the DT based boot also In-Reply-To: <1412948442-19896-3-git-send-email-t-kristo@ti.com> References: <1412948442-19896-1-git-send-email-t-kristo@ti.com> <1412948442-19896-3-git-send-email-t-kristo@ti.com> Message-ID: <20141010134308.GA15977@kahuna> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 16:40-20141010, Tero Kristo wrote: > This allows to pass platform information during a DT boot also, currently > this is completely ignored. Needed for supporting the platform specific > regulator set_voltage / get_voltage ops for the SMPS regulators. > > Signed-off-by: Tero Kristo > To: Liam Girdwood > To: Mark Brown > --- > drivers/regulator/twl-regulator.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c > index 0b4f866..2c4fa06 100644 > --- a/drivers/regulator/twl-regulator.c > +++ b/drivers/regulator/twl-regulator.c > @@ -1103,9 +1103,9 @@ static int twlreg_probe(struct platform_device *pdev) > if (match) { > template = match->data; > id = template->desc.id; > + drvdata = dev_get_platdata(&pdev->dev); > initdata = of_get_regulator_init_data(&pdev->dev, > pdev->dev.of_node); > - drvdata = NULL; > } else { > id = pdev->id; > initdata = dev_get_platdata(&pdev->dev); > -- > 1.7.9.5 > please post this separately and liam, mark need to be in cc. Unfortunately, I think we might be pushed back with pdata should'nt be in of boot. So a slightly longer commit message might be necessary. -- Regards, Nishanth Menon