All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Matt Ranostay <mranostay@gmail.com>
Cc: galak@codeaurora.org, zonque@gmail.com,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 2/3] cap11xx: Add support for various cap11xx devices
Date: Fri, 10 Oct 2014 10:29:52 -0700	[thread overview]
Message-ID: <20141010172952.GA32974@dtor-ws> (raw)
In-Reply-To: <1412914983-3742-3-git-send-email-mranostay@gmail.com>

Hi Matt,

On Thu, Oct 09, 2014 at 09:23:02PM -0700, Matt Ranostay wrote:
> @@ -63,7 +60,25 @@ struct cap11xx_priv {
>  	struct input_dev *idev;
>  
>  	/* config */
> -	unsigned short keycodes[CAP11XX_NUM_CHN];
> +	unsigned int num_channels;
> +	u32 keycodes[];

Any particular reason you decided to keep num_channels field givfen that
the same data is accessible through priv->idev->keycodemax?

Thanks.

-- 
Dmitry

  reply	other threads:[~2014-10-10 17:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-10  4:23 [PATCH v5 0/3] cap1106: add support for cap11xx variants Matt Ranostay
2014-10-10  4:23 ` [PATCH v5 1/3] cap11xx: make driver generic for variant support Matt Ranostay
2014-10-10  4:23 ` [PATCH v5 2/3] cap11xx: Add support for various cap11xx devices Matt Ranostay
2014-10-10 17:29   ` Dmitry Torokhov [this message]
2014-10-10 21:06     ` Matt Ranostay
2014-10-10  4:23 ` [PATCH v5 3/3] cap11xx: support for irq-active-high option Matt Ranostay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141010172952.GA32974@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=linux-input@vger.kernel.org \
    --cc=mranostay@gmail.com \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.