From: sudipm.mukherjee@gmail.com (Sudip Mukherjee)
To: kernelnewbies@lists.kernelnewbies.org
Subject: [PATCH] staging: Fix spacing between function name and parentheses
Date: Sat, 11 Oct 2014 10:28:03 +0530 [thread overview]
Message-ID: <20141011045803.GA3112@sudip-PC> (raw)
In-Reply-To: <1412992548-32011-1-git-send-email-xerofoify@gmail.com>
On Fri, Oct 10, 2014 at 09:55:48PM -0400, Nicholas Krause wrote:
> Fixes checkpatch coding style warning about unneeded space
> between function name an parentheses.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> Untested
> drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index 5f9db4c..bbeb0cc 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -412,7 +412,7 @@ struct octeon_hcd {
> type c; \
> while (1) { \
> c.u32 = __cvmx_usb_read_csr32(usb, address); \
> - if (c.s.field op (value)) { \
> + if (c.s.field op(value)) { \
have you read the code before modifying it?
this is not a function.
have you seen how CVMX_WAIT_FOR_FIELD32 is being called?
on every call of CVMX_WAIT_FOR_FIELD32 op is the operator "=="
so when called the macro will be c.s.field == (value).
if your patch is applied then it will become c.s.field ==(value) .. will that be correct ?
thanks
sudip
> result = 0; \
> break; \
> } else if (cvmx_get_cycle() > done) { \
> --
> 1.9.1
>
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
next prev parent reply other threads:[~2014-10-11 4:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 1:55 [PATCH] staging: Fix spacing between function name and parentheses Nicholas Krause
2014-10-11 4:58 ` Sudip Mukherjee [this message]
2014-10-11 5:23 ` Dave Tian
2014-10-11 6:08 ` Sudip Mukherjee
2014-10-11 6:11 ` Dave Tian
2014-10-11 8:27 ` Peter Senna Tschudin
2014-10-11 9:45 ` Sudip Mukherjee
2014-10-11 9:53 ` Kristofer Hallin
2014-10-11 13:44 ` nick
2014-10-11 13:46 ` Kristofer Hallin
2014-10-11 13:52 ` Hugo Mills
2014-10-11 14:17 ` nick
2014-10-11 15:25 ` karthik nayak
2014-10-11 22:18 ` nick
2014-10-12 22:34 ` Valdis.Kletnieks at vt.edu
2014-10-13 2:31 ` nick
2014-10-13 3:15 ` Valdis.Kletnieks at vt.edu
2014-10-13 4:55 ` Sudip Mukherjee
2014-10-14 15:38 ` Adrian Cornish
2014-10-14 18:11 ` Kernel Apprentice
2014-10-14 21:08 ` John de la Garza
2014-10-20 9:17 ` el_es
2014-11-02 0:34 ` Valdis.Kletnieks at vt.edu
2014-11-03 10:05 ` Bjørn Mork
2014-11-04 2:23 ` nick
2014-10-11 14:24 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141011045803.GA3112@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.