From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] vsftpd: Add build option to disable utmpx update code
Date: Sat, 11 Oct 2014 19:25:41 +0200 [thread overview]
Message-ID: <20141011192541.26978885@free-electrons.com> (raw)
In-Reply-To: <1410873450-19158-1-git-send-email-maarten@treewalker.org>
Dear Maarten ter Huurne,
On Tue, 16 Sep 2014 15:17:30 +0200, Maarten ter Huurne wrote:
> This was modeled after a similar option for Dropbear.
>
> The utmpx code is automatically disabled when compiling with musl,
> to avoid a build error due to WTMPX_FILE being undefined. Note that
> musl has an empty utmpx implementation, so no functionality is lost
> by not calling it.
>
> Signed-off-by: Maarten ter Huurne <maarten@treewalker.org>
Since the patch is not only a feature addition, but also fixing a build
issue when using the musl C library:
Tested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
One minor nit below, that can be fixed by Peter when applying:
> +ifneq ($(BR2_PACKAGE_VSFTPD_UTMPX),y)
Positive logic would be better here:
ifeq ($(BR2_PACKAGE_VSFTPD_UTMPX),)
> +VSFTPD_POST_CONFIGURE_HOOKS += VSFTPD_DISABLE_UTMPX
> +endif
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-10-11 17:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 13:17 [Buildroot] [PATCH] vsftpd: Add build option to disable utmpx update code Maarten ter Huurne
2014-10-05 21:46 ` Thomas Petazzoni
2014-10-05 22:17 ` Maarten ter Huurne
2014-10-11 17:25 ` Thomas Petazzoni [this message]
2014-10-12 7:32 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141011192541.26978885@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.