All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/mono: new package
Date: Sun, 12 Oct 2014 11:02:13 +0200	[thread overview]
Message-ID: <20141012110213.5b7c6c8a@free-electrons.com> (raw)
In-Reply-To: <CA+TH9VmaCh+6X7CQVWPctUQTz1mLZyrXB1FyAObNceO_9=BeWQ@mail.gmail.com>

Dear Angelo Compagnucci,

On Sun, 12 Oct 2014 10:44:21 +0200, Angelo Compagnucci wrote:

> Yes, you are right, but changing runtime version means you have to
> recompile a lot of things. This way, you compile at first and simply
> removing .stap_target_installed, you can have free a new mono runtime
> version!
> If you think that it necessary to have them disabled at compile time,
> I'll do it!

Yes, please, that's how we do things for all packages: if a configure
option is there to not build something that is actually disabled in the
Buildroot configuration, then we use that.

> >> +ifneq ($(ASSEMBLY_INCLUDED),)
> >> +$(eval $(host-autotools-package))
> >> +endif
> >
> > Conditional not needed. I think we should ensure at least one runtime
> > version is enabled.
> 
> That's not always true. There is ways in mono to "freeze" the
> assemblies your application requires, so only the mono vm is required.
> Moreover, you can write an application that ships required assemblies
> in your project folder and not using the system wide installed.
> I think that having an option to only compile the vm is good!

Then, the conditional shouldn't be here, but around the dependency of
mono on host-mono.

That being said, I would recommend you to keep things simple for now,
and handle only this use case as a follow-up contribution.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-10-12  9:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-12  7:50 [Buildroot] Mono: new package Angelo Compagnucci
2014-10-12  7:50 ` [Buildroot] [PATCH 1/2] package/monolite: " Angelo Compagnucci
2014-10-12  7:50 ` [Buildroot] [PATCH 2/2] package/mono: " Angelo Compagnucci
2014-10-12  8:25   ` Thomas Petazzoni
2014-10-12  8:44     ` Angelo Compagnucci
2014-10-12  9:02       ` Thomas Petazzoni [this message]
2014-10-12  9:21         ` Angelo Compagnucci
2014-10-12  9:45           ` Thomas Petazzoni
2014-10-12 10:06             ` Angelo Compagnucci
2014-10-12 12:56               ` Thomas Petazzoni
2014-10-12  8:59     ` Angelo Compagnucci
2014-10-12  9:44       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141012110213.5b7c6c8a@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.