All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Motohiro Kanda <kanda.motohiro@gmail.com>
Cc: perfbook@vger.kernel.org
Subject: Re: Typos in perfbook section 5.6 and table 9.7
Date: Sun, 12 Oct 2014 06:10:28 -0700	[thread overview]
Message-ID: <20141012131028.GI4880@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAGfuzXRMegrY3xdfmr7nDE=DQ1O64GdNZvrxoq6JyEFfz6Eynw@mail.gmail.com>

On Thu, Oct 09, 2014 at 10:47:56PM +0900, Motohiro Kanda wrote:
> Hi,
> 
> I enjoy the book so much and am making a Japanese translation here.
> https://sites.google.com/site/kandamotohiro/perfbook

Very good!  I have added this translation to the FAQ.

> I think I have found 2 typos in perfbook. Latest git repo also has these bugs.
> 
> 5.6 Parallel Counting Discussion
> on page 82, in file count.tex says,
> 
> "The per-thread
> variable implementation (count_stat.c) is significantly faster on updates than
> the array-based implementation (count_end.c), but is slower at reads"
> 
> But it should read
> 
> per-thread variable implementation(count_end.c)
> and
> array-based implementation (count_stat.c)
> 
> And according to table 5.1,
> array-based implementation has 408 ns vs.
> per-thread variable implementation has 389 ns.
> 
> so, per-thread variable implementation is a little faster, not slower
> at 1 core read.

Good catch!  This sentence now reads as follows:

	The per-thread-variable implementation (count_end.c)
	is significantly faster on updates than the array-based
	implementation (count_stat.c), but is slower at reads on large
	numbers of cores, and suffers severe lock contention when there
	are many parallel readers.

> Table 9.7  Which Deferred Technique to Choose?
> on page 228 in file whichtochoose.tex says,
> 
> Sequence Locks has "Y" on Updates and Readers Progress Concurrently
> 
> But it should be N because on page 229, it says
> 
> sequence locking does not permit updates and readers to make forward
> progress concurrently

And reference counting, hazard pointers, and RCU should all say "Y".

I have made these changes with your Reported-by.

							Thanx, Paul

> --
> Kanda Motohiro
> --
> To unsubscribe from this list: send the line "unsubscribe perfbook" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


      reply	other threads:[~2014-10-12 13:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-09 13:47 Typos in perfbook section 5.6 and table 9.7 Motohiro Kanda
2014-10-12 13:10 ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141012131028.GI4880@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=kanda.motohiro@gmail.com \
    --cc=perfbook@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.