From: Christoph Hellwig <hch@infradead.org>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfs: Deduplicate code shared by xattr system calls operating on paths
Date: Sun, 12 Oct 2014 10:03:32 -0700 [thread overview]
Message-ID: <20141012170332.GA16885@infradead.org> (raw)
In-Reply-To: <1413133198-2386-1-git-send-email-ebiggers3@gmail.com>
On Sun, Oct 12, 2014 at 11:59:58AM -0500, Eric Biggers wrote:
> The following pairs of system calls dealing with extended attributes only
> differ in their behavior on whether the symbolic link is followed (when
> the named file is a symbolic link):
>
> - setxattr() and lsetxattr()
> - getxattr() and lgetxattr()
> - listxattr() and llistxattr()
> - removexattr() and lremovexattr()
>
> Despite this, the implementations all had duplicated code, so this commit
> redirects each of the above pairs of system calls to a corresponding
> function to which different lookup flags (LOOKUP_FOLLOW or 0) are passed.
>
> For me this reduced the stripped size of xattr.o from 8824 to 8248 bytes.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2014-10-12 17:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-12 16:59 [PATCH] vfs: Deduplicate code shared by xattr system calls operating on paths Eric Biggers
2014-10-12 17:03 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-03-20 3:26 Eric Biggers
2014-03-20 8:13 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141012170332.GA16885@infradead.org \
--to=hch@infradead.org \
--cc=ebiggers3@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.