All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: WANG Chao <wangchao19890207@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Masaru Nomura <massa.nomura@gmail.com>,
	Peng Tao <bergwolf@gmail.com>, Chi Pham <fempsci@gmail.com>,
	Fredrick John Berchmans <fredrickprashanth@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH resend] staging, lustre: fix a sparse error
Date: Sun, 12 Oct 2014 20:17:02 +0100	[thread overview]
Message-ID: <20141012191702.GS7996@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20141010032116.GC9352@dhcp-17-37.nay.redhat.com>

On Fri, Oct 10, 2014 at 11:21:16AM +0800, WANG Chao wrote:

> I think __user annotation is for no dereferencing in kernel space. In
> this case, I think it's fine to override this error by __force. Because
> they're pointers with identical target types.

Umm...  The real question seems to be whether iovec is the right type in
the first place.  Does ->tx_iov ever contain a vector with _userland_
pointers?  If not, it ought to be struct kvec * instead.

  reply	other threads:[~2014-10-12 19:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-09 10:25 [PATCH resend] staging, lustre: fix a sparse error WANG Chao
2014-10-09 12:28 ` Sudip Mukherjee
2014-10-10  3:21   ` WANG Chao
2014-10-12 19:17     ` Al Viro [this message]
2014-10-13  5:58       ` WANG Chao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141012191702.GS7996@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=bergwolf@gmail.com \
    --cc=davem@davemloft.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=fempsci@gmail.com \
    --cc=fredrickprashanth@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=massa.nomura@gmail.com \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=wangchao19890207@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.