From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH 2/5] fs/anon_inodes.c: Simplify control flow in
 anon_inode_getfd()
Date: Sun, 12 Oct 2014 22:07:13 +0100
Message-ID: <20141012210712.GT7996@ZenIV.linux.org.uk>
References: <1413146562-18147-1-git-send-email-ebiggers3@gmail.com>
 <1413146562-18147-2-git-send-email-ebiggers3@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
To: Eric Biggers <ebiggers3@gmail.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <1413146562-18147-2-git-send-email-ebiggers3@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Sun, Oct 12, 2014 at 03:42:39PM -0500, Eric Biggers wrote:

>  	file = anon_inode_getfile(name, fops, priv, flags);
>  	if (IS_ERR(file)) {
> -		error = PTR_ERR(file);
> -		goto err_put_unused_fd;
> +		put_unused_fd(fd);
> +		return PTR_ERR(file);
>  	}
>  	fd_install(fd, file);

at least slap unlikely() on that if (IS_ERR(...))...