From: Theodore Ts'o <tytso@mit.edu>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] ext4: Replace open coded mdata csum feature to helper function v2
Date: Mon, 13 Oct 2014 03:59:30 -0400 [thread overview]
Message-ID: <20141013075930.GA9738@thunk.org> (raw)
In-Reply-To: <1413147967-30487-1-git-send-email-dmonakhov@openvz.org>
On Mon, Oct 13, 2014 at 01:06:06AM +0400, Dmitry Monakhov wrote:
> Besides the fact that this replacement improves code readability
> it also protects from errors caused direct EXT4_S(sb)->s_es manipulation
> which may result attempt to use uninitialized csum machinery.
Thanks, applied.
- Ted
next prev parent reply other threads:[~2014-10-13 7:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-12 21:06 [PATCH 1/2] ext4: Replace open coded mdata csum feature to helper function v2 Dmitry Monakhov
2014-10-12 21:06 ` [PATCH 2/2] ext4: ext4_init_block_bitmap move error report out of atomic context Dmitry Monakhov
2014-10-13 8:00 ` Theodore Ts'o
2014-10-13 7:59 ` Theodore Ts'o [this message]
2014-10-13 16:43 ` [PATCH 1/2] ext4: Replace open coded mdata csum feature to helper function v2 Darrick J. Wong
2014-10-13 17:02 ` Dmitry Monakhov
2014-10-13 17:28 ` Darrick J. Wong
2014-10-13 21:11 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141013075930.GA9738@thunk.org \
--to=tytso@mit.edu \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.