From: Alexander Aring <alex.aring@gmail.com>
To: Martin Townsend <mtownsend1973@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org,
marcel@holtmann.org, jukka.rissanen@linux.intel.com,
Martin Townsend <martin.townsend@xsilon.com>
Subject: Re: [PATCH v6 bluetooth-next] 6lowpan: Use skb_cow in IPHC decompression.
Date: Mon, 13 Oct 2014 12:34:54 +0200 [thread overview]
Message-ID: <20141013103452.GC20544@omega> (raw)
In-Reply-To: <1413194456-26351-2-git-send-email-martin.townsend@xsilon.com>
On Mon, Oct 13, 2014 at 11:00:56AM +0100, Martin Townsend wrote:
> Currently there are potentially 2 skb_copy_expand calls in IPHC
> decompression. This patch replaces this with one call to
> skb_cow which will check to see if there is enough headroom
> first to ensure it's only done if necessary and will handle
> alignment issues for cache.
> As skb_cow uses pskb_expand_head we ensure the skb isn't shared from
> bluetooth and ieee802.15.4 code that use the IPHC decompression.
>
> Signed-off-by: Martin Townsend <martin.townsend@xsilon.com>
Okay, we don't use the goto drop; below and currently this will always
return -EINVAL. You will fix that in your next patches, so it doesn't
matter right now. Also this will correct a little bit the errno value.
Great job Martin.
Acked-by: Alexander Aring <alex.aring@gmail.com>
Marcel, please wait for jukka's acked here, then we are sure that we
didn't break anything in bluetooth 6lowpan.
- Alex
next prev parent reply other threads:[~2014-10-13 10:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-13 10:00 [PATCH v6 bluetooth-next] 6lowpan: Use skb_cow in IPHC decompression Martin Townsend
2014-10-13 10:00 ` Martin Townsend
2014-10-13 10:34 ` Alexander Aring [this message]
2014-10-13 11:49 ` Jukka Rissanen
2014-10-13 13:10 ` Martin Townsend
2014-10-13 14:44 ` Jukka Rissanen
2014-10-13 14:56 ` Martin Townsend
2014-10-13 15:09 ` Jukka Rissanen
2014-10-13 15:47 ` Martin Townsend
2014-10-13 16:00 ` Martin Townsend
2014-10-13 16:00 ` Martin Townsend
2014-10-13 16:07 ` Johan Hedberg
2014-10-13 17:11 ` Alexander Aring
2014-10-13 17:22 ` Alexander Aring
2014-10-14 8:35 ` Jukka Rissanen
2014-10-14 8:38 ` Alexander Aring
2014-10-17 14:15 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141013103452.GC20544@omega \
--to=alex.aring@gmail.com \
--cc=jukka.rissanen@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=martin.townsend@xsilon.com \
--cc=mtownsend1973@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.