From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH v3] Separate runtime debug output from debug
 symbols
Date: Mon, 13 Oct 2014 13:42:04 +0200
Message-ID: <20141013114204.GA26047@aepfle.de>
References: <1412779865-31148-1-git-send-email-olaf@aepfle.de>
	<21557.21810.882724.782414@mariner.uk.xensource.com>
	<20141008153214.GA8658@aepfle.de>
	<21557.23047.856785.929974@mariner.uk.xensource.com>
	<21557.23217.811751.505795@mariner.uk.xensource.com>
	<20141008160043.GA14570@aepfle.de>
	<21557.24983.788375.204936@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <21557.24983.788375.204936@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Tim Deegan <tim@xen.org>, xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>, Samuel Thibault <samuel.thibault@ens-lyon.org>, Wei Liu <wei.liu2@citrix.com>, David Scott <dave.scott@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, Oct 08, Ian Jackson wrote:

> Olaf Hering writes ("Re: [PATCH v3] Separate runtime debug output from debug symbols"):
> > On Wed, Oct 08, Ian Jackson wrote:
> > > I do object to a change to the default, which AFAICT is what happens
> > > in your patch.
> > 
> > How does it change the default? Confik.mk has:
> 
> Sorry, I wasn't clear.  I mean that -g should remain the default even
> in debug=n builds of Xen.
> 
> >  19 # A debug build of Xen and tools?
> >  20 debug ?= y
> >  21 debug_symbols ?= $(debug)
> > 
> > Which means its always on.
> 
> If debug=n, -g is turned off.  The user might do that.  Also we
> routinely set debug=n during the last stages of the release process.

So how do we proceed here?

v3 of the patch is fine. It removes the hardcoded -g from more places.
The result is more free diskspace if one requests to compile the source
without -g. The default remains the same. 
If one does configure --disable-debug he may have a reason to do so.
Still "make debug_symbols=y" will build the whole thing with -g.

What the default for both knobs should be and how the default is
supposed to be set is a separate discussion not belonging to this.


Olaf