From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/nouveau/disp: Use NULL for pointers Date: Mon, 13 Oct 2014 13:47:51 +0200 Message-ID: <20141013114749.GA16186@ulmo> References: <1405944178-3500-1-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0560056179==" Return-path: Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46]) by gabe.freedesktop.org (Postfix) with ESMTP id D6EB489FC0 for ; Mon, 13 Oct 2014 04:47:53 -0700 (PDT) Received: by mail-wg0-f46.google.com with SMTP id l18so8402452wgh.17 for ; Mon, 13 Oct 2014 04:47:53 -0700 (PDT) In-Reply-To: <1405944178-3500-1-git-send-email-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ben Skeggs Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0560056179== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Kj7319i9nmIyA2yE" Content-Disposition: inline --Kj7319i9nmIyA2yE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 21, 2014 at 02:02:58PM +0200, Thierry Reding wrote: > From: Thierry Reding >=20 > The return type of exec_lookup() is struct nvkm_output *, so it should > return NULL rather than 0. >=20 > Signed-off-by: Thierry Reding > --- > drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c b/drivers/gp= u/drm/nouveau/core/engine/disp/nvd0.c > index fa30d8196f35..ebf64e1d0a70 100644 > --- a/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c > +++ b/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c > @@ -939,7 +939,7 @@ exec_lookup(struct nv50_disp_priv *priv, int head, in= t or, u32 ctrl, > case 0x00000900: type =3D DCB_OUTPUT_DP; mask =3D 2; break; > default: > nv_error(priv, "unknown SOR mc 0x%08x\n", ctrl); > - return 0x0000; > + return NULL; > } > } > =20 Ping? Thierry --Kj7319i9nmIyA2yE Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUO7vlAAoJEN0jrNd/PrOhIYkQAJuYLh9CmDSUqiApE1Fxj4oS WHw4+dS3QXijeyWVnbC0kpWDaL6eRcF3gCWVZSqwr91QYBjcMrzigpnUF4SuR7yp y6y137pik+jlzaL4fe1ngXsjq1J1PMys8F+Vzgs2idnjWD6+d6zTh2Bj6685rr/8 RpnID6yzvA7Eb/1a/UIiynL+cMbyVwlvPEnM2Wyp8X8QejwHaYKFSXVPgzv8PNf0 IomOI10xBedoLb9U4/O9hb/xl6iUnY5O8WgmknTdiaKRP2tsjTW4SC9LjeDiqc7c mpLwN5cIb/zodc71OkUnBTFuCYbVVSeHR9xlDpPHCVr+DZJTkBM2mG/I+OVOhKhE Q+lFwzxE0xjFZ6lU1/hlcxZzjQFc3KveWxy8sv2UKAK2xYHG5D6MeudZOFfvRtMq zXURntvRXMQNiZGJCul+bDiP5YUm9icFe2W1Rv9A0klR6i4wDi7fUnzoS8vNldKy ccUb7T25ycybMhAul78hQgIP+YrvcPax98i20xCxo2VLH2z6/43lrtlkvyW5iKTE DDGnrhwtCXH0xlat1JLiDXbOSiisrbv6lxrFy1iAVVbYTXn7IBFCcvyG3RoKRv+I vxPLKv26QscbqADU0YxnkvMAIFT5bYBpvo1JS/sD0GrrSDxDzVmgU7NHmZw5Fz6J fyv2WoP21TlAVjQ1FU3z =gxqn -----END PGP SIGNATURE----- --Kj7319i9nmIyA2yE-- --===============0560056179== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0560056179==--