From: Tony Lindgren <tony@atomide.com>
To: He YunLei <heyunlei@huawei.com>
Cc: linux-kernel@vger.kernel.org, grant.likely@linaro.org,
robh+dt@kernel.org, wangbintian@huawei.com,
liguozhu@hisilicon.com, kong.kongxinwei@hisilicon.com,
linux-omap@vger.kernel.org
Subject: Re: [RFC PATCH] pinctrl: pinctrl-single.c: init pinctrl single at arch_initcall time
Date: Mon, 13 Oct 2014 08:42:19 -0700 [thread overview]
Message-ID: <20141013154218.GA5192@atomide.com> (raw)
In-Reply-To: <5438F1F6.4080300@huawei.com>
* He YunLei <heyunlei@huawei.com> [141011 02:03]:
> On 2014/10/9 2:10, Tony Lindgren wrote:
> >* He YunLei <heyunlei@huawei.com> [141007 18:43]:
> >>
> >>Thanks for your review and I am really appreciated it, but in our arm
> >>platform, we haven't custom initcall levels for other drivers. Although
> >>deferred probe helps other drivers to register well, we are also confused
> >>for the issues of lots of pin request errors debug output while booting the
> >>kernel. Besides, if the number is bigger than the limited number, whether
> >>deferred probe can solve this problem.
> >
> >OK. Care to provide some examples where this happens on your
> >platform?
> >
> >Note that we already have pinctrl very early in drivers/Makefile.
> >What are the early users for pinctrl-single in your setup?
> >
> >Regards,
> >
> >Tony
> >
> >.
> >
> In our platform we use subsys_initcall in I2C, and fs_initcall in PMIC, Both
> of them are early than pinctrl-single. Although they register well
> with the aid of deferred probe, it's really confused us that pins request
> deferred. Why can't we setup pinctrl-single earlier to reduce these
> messages.
How about make the I2C controller just regular module_init?
We're planning to do that for omaps as soon as we have made omap3
DT only as we still have some board-*.c files.
Presumably your PMIC is also on I2C and you need the PMIC for
regulators?
In that case you can just make the PMICinit normal module_init too.
Regards,
Tony
prev parent reply other threads:[~2014-10-13 15:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 10:31 [RFC PATCH] pinctrl: pinctrl-single.c: init pinctrl single at arch_initcall time He YunLei
2014-09-29 17:54 ` Tony Lindgren
2014-10-08 1:42 ` He YunLei
2014-10-08 18:10 ` Tony Lindgren
2014-10-11 9:01 ` He YunLei
2014-10-13 15:42 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141013154218.GA5192@atomide.com \
--to=tony@atomide.com \
--cc=grant.likely@linaro.org \
--cc=heyunlei@huawei.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wangbintian@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.