From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] xentop: Dynamically expand some columns Date: Mon, 13 Oct 2014 16:09:37 -0400 Message-ID: <20141013200937.GA3874@laptop.dumpdata.com> References: <542D21B202000091000DBE23@prv-mh.provo.novell.com> <542D78EC.9030505@citrix.com> <542D282502000091000DBE31@prv-mh.provo.novell.com> <20141002170505.GH1715@laptop.dumpdata.com> <1412326830.423.13.camel@citrix.com> <543BB3A702000091000DD4D7@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <543BB3A702000091000DD4D7@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Charles Arnold Cc: Andrew Cooper , Ian Campbell , xen-devel List-Id: xen-devel@lists.xenproject.org On Mon, Oct 13, 2014 at 11:12:39AM -0600, Charles Arnold wrote: > >>> On 10/3/2014 at 03:00 AM, Ian Campbell wrote: > > On Thu, 2014-10-02 at 13:05 -0400, Konrad Rzeszutek Wilk wrote: > >> On Thu, Oct 02, 2014 at 10:25:41AM -0600, Charles Arnold wrote: > >> > >>> On 10/2/2014 at 10:10 AM, Andrew Cooper wrote: > >> > > On 02/10/14 16:58, Charles Arnold wrote: > >> > >> Allow certain xentop columns to automatically expand as the amount > >> > >> of data reported gets larger. The columns allowed to expand are: > >> > >> > >> > >> NETTX(k), NETRX(k), VBD_RD, VBD_WR, VBD_RSECT, VBD_WSECT > >> > >> > >> > >> Author: Markus Hauschild > >> > >> Signed-off-by: Charles Arnold > >> > > > >> > > In principle, very nice. (I have wanted to see about doing this for a > >> > > while now, but very far down the todo list) > >> > > > >> > > How about the NAME field? 9 characters isn't enough for some people. > >> > > >> > Sure, and any others that might need it. But what to do about the '-f' > > flag > >> > which says show me the full VM name but the flag doesn't adjust the entire > >> > column. By automatically showing the full name and adjusting the column > >> > appropriately it makes this flag pointless (which I'm ok with). > >> > >> Perhaps this functionality should be under that option? > >> > >> I am a bit hesistant about this as there are some users of xentop that > >> use it for their monitoring. What I can't remember is if they use the > >> batched mode or not - and if they scan for specific strings (and length). > >> > >> This would (I think?) throw a wrench in that? > > > > IMHO people who are parsing the output of tools such as this ought to be > > prepared to deal with occasional changes in the precise content of the > > output across Xen releases. > > > > If they aren't happy with that then they should file wishlist bugs (or > > better: patches) asking for an extensible/machine-readable format to be > > output upon request, or for libxenstat to be exposed and made API > > stable, or some other functionality which solves their need. > > > > Otherwise we find ourselves in a position where useful patches like > > Charles' and similar patches which add genuinely useful output for human > > readers can never be accepted. > > So do we get a thumbs up on this? If so can someone take the patch (I prefer v3 which aligns the name if -f is used, but v2 would satisfy the customer). I am OK with either patch, so Released-Acked-by: Konrad Rzeszutek Wilk on either v2 or v3. > > - Charles > >