All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Michael Haggerty <mhagger@alum.mit.edu>
Subject: Re: [PATCH 0/3] "-x" tracing option for tests
Date: Mon, 13 Oct 2014 17:07:29 -0400	[thread overview]
Message-ID: <20141013210729.GA15969@peff.net> (raw)
In-Reply-To: <xmqqd29v4yl1.fsf@gitster.dls.corp.google.com>

On Mon, Oct 13, 2014 at 11:24:42AM -0700, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> > These patches are pulled out of the prune-mtime series I posted
> > earlier[1]. The discussion veered off and there's no reason that the two
> > topics need to be part of the same series.
> 
> These look all sensible.
> 
> Is your plan to reroll the prune-mtime stuff on top of these?  The
> additional safety those patches would give us is valuable and they
> are pretty straight-forward---I was hoping to have them in the 2.2
> release.

Yes, I've delayed while thinking about the issues that Michael raised.
There are basically two paths I see:

  1. These do not solve all problems/races, but are a solid base and
     sensible path forward for further changes which we can worry about
     later.

  2. There is a better way to provide prune safety, and these patches
     will get in the way of doing that.

I wanted to make sure we are on path (1) and not path (2). :)

I'll try to send out a re-roll tonight.

-Peff

  reply	other threads:[~2014-10-13 21:07 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-10  6:06 [PATCH 0/3] "-x" tracing option for tests Jeff King
2014-10-10  6:07 ` [PATCH 1/3] t5304: use test_path_is_* instead of "test -f" Jeff King
2014-10-10  6:11 ` [PATCH 2/3] t5304: use helper to report failure of "test foo = bar" Jeff King
2014-10-13 16:10   ` Jonathan Nieder
2014-10-13 21:15     ` Jeff King
2014-10-13 21:31       ` Jonathan Nieder
2014-10-13 21:33         ` Junio C Hamano
2014-10-13 21:38           ` Jonathan Nieder
2014-10-13 21:56             ` Junio C Hamano
2014-10-13 21:36         ` Jeff King
2014-10-10  6:13 ` [PATCH 3/3] test-lib.sh: support -x option for shell-tracing Jeff King
2014-10-10  6:21   ` Jeff King
2014-10-10  6:47     ` [PATCH v2 " Jeff King
2014-10-13 18:43       ` Junio C Hamano
2014-10-13 22:22       ` Junio C Hamano
2014-10-13 22:31         ` Junio C Hamano
2014-10-13 22:33         ` Jeff King
2014-10-13 22:38           ` Junio C Hamano
2014-10-13 22:43           ` Jeff King
2014-10-13 23:14             ` Junio C Hamano
2014-10-14  0:46               ` Jeff King
2014-10-10  6:27   ` [PATCH " Jeff King
2014-10-13 18:24 ` [PATCH 0/3] "-x" tracing option for tests Junio C Hamano
2014-10-13 21:07   ` Jeff King [this message]
2014-10-14  8:52     ` Michael Haggerty
2014-10-14 13:44       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141013210729.GA15969@peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mhagger@alum.mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.