All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Yang <weiyang@linux.vnet.ibm.com>
To: michaele@au1.ibm.com
Cc: linuxppc-dev@lists.ozlabs.org, Gavin Shan <gwshan@linux.vnet.ibm.com>
Subject: Re: [PATCH] powerpc/pci: remove duplicate declaration of pci_bus_find_capability
Date: Tue, 14 Oct 2014 14:41:21 +0800	[thread overview]
Message-ID: <20141014064121.GA7990@richard> (raw)
In-Reply-To: <20141014062539.GA5639@richard>

On Tue, Oct 14, 2014 at 02:25:39PM +0800, Wei Yang wrote:
>On Fri, Sep 19, 2014 at 08:18:02PM +1000, Gavin Shan wrote:
>>On Fri, Sep 19, 2014 at 05:25:22PM +0800, Wei Yang wrote:
>>>pci_bus_find_capability() is decleared in pci.h, so it is not necessary to do
>>>it again.
>>>
>>>This patch removes it.
>>>
>>>Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com>
>>
>>Reviewed-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
>>
>>Thanks,
>>Gavin
>
>Hi, Michael
>
>I see this is not merged in your tree. Do you have some comment?
>

Oops,

As pointed by Gavin, it is in the next branch.

>>
>>>---
>>> arch/powerpc/kernel/pci-common.c |    1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>>diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c
>>>index b2814e2..9cfa069 100644
>>>--- a/arch/powerpc/kernel/pci-common.c
>>>+++ b/arch/powerpc/kernel/pci-common.c
>>>@@ -1561,7 +1561,6 @@ EARLY_PCI_OP(write, byte, u8)
>>> EARLY_PCI_OP(write, word, u16)
>>> EARLY_PCI_OP(write, dword, u32)
>>>
>>>-extern int pci_bus_find_capability (struct pci_bus *bus, unsigned int devfn, int cap);
>>> int early_find_capability(struct pci_controller *hose, int bus, int devfn,
>>> 			  int cap)
>>> {
>>>-- 
>>>1.7.9.5
>>>
>
>-- 
>Richard Yang
>Help you, Help me

-- 
Richard Yang
Help you, Help me

      reply	other threads:[~2014-10-14  6:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-19  9:25 [PATCH] powerpc/pci: remove duplicate declaration of pci_bus_find_capability Wei Yang
2014-09-19 10:18 ` Gavin Shan
2014-10-14  6:25   ` Wei Yang
2014-10-14  6:41     ` Wei Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141014064121.GA7990@richard \
    --to=weiyang@linux.vnet.ibm.com \
    --cc=gwshan@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=michaele@au1.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.