From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 04/15] drm/panel: s6e8aa0: Use standard MIPI DSI function Date: Tue, 14 Oct 2014 11:46:16 +0200 Message-ID: <20141014094614.GE18993@ulmo> References: <1413195395-3355-1-git-send-email-thierry.reding@gmail.com> <1413195395-3355-4-git-send-email-thierry.reding@gmail.com> <543BDDFC.2090500@samsung.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0424722834==" Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 5637589533 for ; Tue, 14 Oct 2014 02:46:19 -0700 (PDT) Received: by mail-wi0-f177.google.com with SMTP id fb4so9659426wid.4 for ; Tue, 14 Oct 2014 02:46:18 -0700 (PDT) In-Reply-To: <543BDDFC.2090500@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrzej Hajda Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0424722834== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9l24NVCWtSuIVIod" Content-Disposition: inline --9l24NVCWtSuIVIod Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 13, 2014 at 04:13:16PM +0200, Andrzej Hajda wrote: > On 10/13/2014 12:16 PM, Thierry Reding wrote: > > From: Thierry Reding > >=20 > > Use the newly introduced mipi_dsi_set_maximum_return_packet_size() > > function to replace an open-coded version. > >=20 > > Signed-off-by: Thierry Reding > > --- > > drivers/gpu/drm/panel/panel-s6e8aa0.c | 16 ++-------------- > > 1 file changed, 2 insertions(+), 14 deletions(-) > >=20 > > diff --git a/drivers/gpu/drm/panel/panel-s6e8aa0.c b/drivers/gpu/drm/pa= nel/panel-s6e8aa0.c > > index 0f85a7c37687..c31e2953f290 100644 > > --- a/drivers/gpu/drm/panel/panel-s6e8aa0.c > > +++ b/drivers/gpu/drm/panel/panel-s6e8aa0.c > > @@ -800,27 +800,15 @@ static void s6e8aa0_panel_init(struct s6e8aa0 *ct= x) > > } > > =20 > > static void s6e8aa0_set_maximum_return_packet_size(struct s6e8aa0 *ctx, > > - int size) > > + u16 size) >=20 >=20 > I guess this whole function should be removed and direct call to > mipi_dsi_set_maximum_return_packet_size should be used. There's additional error handling logic in this function which would have needed extra untangling. Since I don't have the hardware to test this change I kept it to a minimum possible to reduce the risk of accidentally breaking anything. Feel free to send a follow-on patch cleaning this up as you see fit. Thierry --9l24NVCWtSuIVIod Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIbBAEBAgAGBQJUPPDmAAoJEN0jrNd/PrOhuO0P+NXU/zY6tSO7mPWjabpbcbNo Rfzt68s+Vk/XXQX6AyWkWN9KVAJMVfm0NHgZHCJctvsHmCfCLEHvGgLZ6gBj9RUb vc40XZEGGG8BAU5G5pKMfFp644DWE0gwYFF8j4P35xxgqYveKGFTbttprk7utDi9 sbo+FJM4D2Dm+H5b4kXbJTFse57Kv4q5qCq+KhKJbxriFnt5tP0CUPp/tew16KOe i770ZjE/qsNWaka7UyTZwsPntQKRAwY4JbfzM3iD/lRedvXtdZHI9fBKYglc9Y1c Mi/Ad+LuwuRs/FYf0XXsSqT/9jqGKPUnB4ccuAXCNAS+a3kLKsrWytNh9YJlhjkN BJI26kPp07GFVWOnEB9eINTPcWTVBOYSyyjKUzG+NDBX2092/zGwchhnDFubKCzt yyRNv/LVTlGPxZm4FiDYqBadseh0y9hXnFoMBdRnZJo9ROBsq2bg0ZPvYwWFHXmy IBgqf9kPSlZEohFLGdZP9QNXYICEwvEOgPijSDuejyNZzOWftiXCeay7skub5kUw pM7HNQ3iyoqLnpdwdvzEH70FQfu7Sv6wR8TMoPls2biJMYs8HWCgGF7i+rbo7Kkd DkSjTlhHRedYx5/Dh6C86LWNZTiLW1p5pMkFIFedbejBcn1aa7iAxWyWsKi8boFv oIClI87oPy3PcLbjOSw= =ilnE -----END PGP SIGNATURE----- --9l24NVCWtSuIVIod-- --===============0424722834== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0424722834==--