From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH for-xen-4.5] tools/hotplug: use configure --sysconfdir result Date: Tue, 14 Oct 2014 16:18:33 +0200 Message-ID: <20141014141833.GA17988@aepfle.de> References: <1413269723-28599-1-git-send-email-olaf@aepfle.de> <21565.11532.10089.34628@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <21565.11532.10089.34628@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Wei Liu , Ian Campbell , Stefano Stabellini , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Tue, Oct 14, Ian Jackson wrote: > Olaf Hering writes ("[PATCH for-xen-4.5] tools/hotplug: use configure --sysconfdir result"): > > ... instead of hardcoding values and guess where they config files may > > be. Also use the result of --with-sysconfig-leaf-dir. > > This looks plausible but I haven't tested it. Olaf, have you done > before-and-after test builds and checked that the results in > dist/install/ are identical ? I have verified that the values are what they are supposed to be. My /opt/xen/staging-upstream/etc/init.d/xencommons has xencommons_config=/opt/xen/staging-upstream/etc/sysconfig. Similar with odd values for --sysconfdir and --with-sysconfig-leaf-dir. Olaf