Re: [PATCH] vmx, apicv: fix save/restore issue with apicv

[Olaf Hering <olaf@aepfle.de>]

On Sat, Oct 11, Yang Zhang wrote:

> From: Yang Zhang <yang.z.zhang@Intel.com>
> 
> This patch fix two issues:
> 
> 1. Interrupts on PIR are lost during save/restore. Syncing the PIR
> into IRR during save will fix it.
> 
> 2. EOI exit bitmap doesn't setup correctly after restore. Here we
> will construct the eoi exit bimap via (IRR | ISR). Though it may cause
> unnecessary eoi exit of the interrupts that pending in IRR or ISR during
> save/resotre, each pending interrupt only causes one vmexit. The
> subsequent interrupts will adjust the eoi exit bitmap correctly. So
> the performace hurt can be ignored.
> 
> Signed-off-by: Yang Zhang <yang.z.zhang@Intel.com>
> ---
> Hi Olaf and Malcolm, Can you help to retest it? Because the key part
> is changed in this patch, so i'm not sure whether it still works in
> your side.
> 
> Also, Olaf, is it ok to add your SOB in this patch? If yes, I can resend
> it to do it.

Yes, thats fine.

I have tested this version and save/restore still works with current
staging.

Olaf