From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Josh Boyer <jwboyer@fedoraproject.org>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
Ralf Hoppe <rhoppe@de.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390/hmcdrv: Restrict s390 HMC driver to S390 arch
Date: Tue, 14 Oct 2014 17:03:33 +0200 [thread overview]
Message-ID: <20141014170333.788efc91@mschwide> (raw)
In-Reply-To: <20141014141342.GA30995@hansolo.jdub.homelinux.org>
On Tue, 14 Oct 2014 10:13:42 -0400
Josh Boyer <jwboyer@fedoraproject.org> wrote:
> This driver is only usable on 64-bit s390 machines. Mark the Kconfig
> dependencies to that users on other architectures are not prompted for it.
>
> Fixes: 8f933b1043e1e5 ("s390/hmcdrv: HMC drive CD/DVD access")
> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
> ---
> drivers/s390/char/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/char/Kconfig b/drivers/s390/char/Kconfig
> index dc24ecfac2d1..db2cb1f8a1b5 100644
> --- a/drivers/s390/char/Kconfig
> +++ b/drivers/s390/char/Kconfig
> @@ -105,7 +105,7 @@ config SCLP_ASYNC
> config HMC_DRV
> def_tristate m
> prompt "Support for file transfers from HMC drive CD/DVD-ROM"
> - depends on 64BIT
> + depends on S390 && 64BIT
> select CRC16
> help
> This option enables support for file transfers from a Hardware
Indeed. I'll queue this patch to the fixes branch of the s390 tree.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
prev parent reply other threads:[~2014-10-14 15:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 14:13 [PATCH] s390/hmcdrv: Restrict s390 HMC driver to S390 arch Josh Boyer
2014-10-14 15:03 ` Martin Schwidefsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141014170333.788efc91@mschwide \
--to=schwidefsky@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jwboyer@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=rhoppe@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.